Repository navigation
fix(web): remove falsy sole-child primitives when replacing content - #3573
Merged
ryansolid merged 2 commits intoSep 22, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: f71aa9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A sole dynamic child of 0 or NaN is tracked as the raw primitive. Truthiness checks in insertExpression skipped cleanup, so a later element or array was appended beside the old text node and zeros accumulated on later toggles.
…olidjs#3571) Array.isArray(current) drops the last truthiness read of current in insertExpression. Co-authored-by: Claude via Cursor <noreply@cursor.com>
ryansolid
force-pushed
the
fix/sole-child-falsy-primitive-3571
branch
from
September 22, 2026 09:08
ddc2c65 to
f71aa9a
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3571 on the Solid 2.0.0-rc.9 line.
insertExpressionkeeps a sole primitive child as the raw value incurrent. The node and array replacement paths tested that value by truthiness, so0andNaNskipped cleanup. The old text node stayed, new content was appended after it, and zeros accumulated on later toggles.Those checks now use
current != null, so the text node is replaced or removed. Empty string andfalsestill never becomecurrent(flattendrops them first).Test plan
0→ element →0→ number (incl. second toggle),NaN,0↔ array, anditems().length && <For>Notes
Implementation assisted by AI; reviewed before opening. Authorship Yahiro025-only.