Fix rails new#334
Open
forkata wants to merge 2 commits into
Open
Conversation
Brings it more inline with what we're using in other extensions. Important updates to include the manifest.js file and postgres config so that our tests can actually run again.
This also removed rubocop and simplecov from being explicit dependencies of the gem, and removes the simplecov gems from being added to the dummy app Gemfile so they are not added twice.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change updates the
bin/rails-newbinstub and updates the gem dependencies to ensure CI can run the specs.There are some failures from solidus_paypal_commerce being copied which are failing, but that will be resolved in core, so it is not relevant to this change.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: