Skip to content

Fix crash when stored playground language state is invalid #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martin-henz wants to merge 6 commits into
base: master
Choose a base branch
from
+17 −8
Open

Fix crash when stored playground language state is invalid #3646

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fbf182a
Fix crash when stored playground language state is invalid
martin-henz Mar 10, 2026
33375a8
Merge branch 'master' into invalidLang
martin-henz Mar 10, 2026
3c0f115
Merge branch 'master' into invalidLang
martin-henz Mar 11, 2026
466df3b
Merge branch 'master' into invalidLang
martin-henz Mar 16, 2026
7a5290f
Merge branch 'master' into invalidLang
RichDom2185 Mar 16, 2026
66a3eb9
Merge branch 'master' into invalidLang
martin-henz Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions src/pages/createStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { throttle } from 'lodash';
import createSagaMiddleware from 'redux-saga';
import { SourceActionType } from 'src/commons/utils/ActionsHelper';

import { defaultState, OverallState } from '../commons/application/ApplicationTypes';
import { ALL_LANGUAGES, defaultState, OverallState } from '../commons/application/ApplicationTypes';
import rootReducer from '../commons/application/reducers/RootReducer';
import MainSaga from '../commons/sagas/MainSaga';
import { generateOctokitInstance } from '../commons/utils/GitHubPersistenceHelper';
Expand Down Expand Up @@ -82,15 +82,24 @@ function loadStore(loadedStore: SavedState | undefined) {
externalLibrary: loadedStore.playgroundExternalLibrary
? loadedStore.playgroundExternalLibrary
: defaultState.workspaces.playground.externalLibrary,
context: {
...defaultState.workspaces.playground.context,
chapter: loadedStore.playgroundSourceChapter
context: (() => {
const chapter = loadedStore.playgroundSourceChapter
? loadedStore.playgroundSourceChapter
: defaultState.workspaces.playground.context.chapter,
variant: loadedStore.playgroundSourceVariant
: defaultState.workspaces.playground.context.chapter;
const variant = loadedStore.playgroundSourceVariant
? loadedStore.playgroundSourceVariant
: defaultState.workspaces.playground.context.variant
}
: defaultState.workspaces.playground.context.variant;
const validCombination = ALL_LANGUAGES.some(
lang => lang.chapter === chapter && lang.variant === variant
);
return {
...defaultState.workspaces.playground.context,
chapter: validCombination
? chapter
: defaultState.workspaces.playground.context.chapter,
variant: validCombination ? variant : defaultState.workspaces.playground.context.variant
};
})()
}
},
stories: {
Expand Down
Loading