Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore: Change titles of some Grafana panels #63952

Open
varungandhi-src wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: Change titles of some Grafana panels #63952

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c7dc04
chore: Change titles of some Grafana panels
varungandhi-src Jul 19, 2024
6377d9d
generated updated docs
burmudar Jul 29, 2024
78880c0
Merge branch 'main' into vg/rename-panels
burmudar Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion monitoring/definitions/containers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func Containers() *monitoring.Dashboard {
},
},
{
Title: "Containers: Provisioning Indicators (not available on server)",
Title: "Containers: Resource utilization (not available on server)",
Copy link
Copy Markdown
Contributor Author

@varungandhi-src varungandhi-src Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this title is different from the other one - is the distinction between service-level (aggregated across multiple containers) vs container-level utilization?

Hidden: false,
Rows: []monitoring.Row{
{
Expand Down
4 changes: 2 additions & 2 deletions monitoring/definitions/shared/provisioning.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
//
// These observables should only use cAdvisor metrics, and are thus only available on
// Kubernetes and docker-compose deployments.
const TitleProvisioningIndicators = "Provisioning indicators (not available on server)"
const TitleResourceUtilization = "Resource utilization (not available on server)"
Copy link
Copy Markdown
Contributor Author

@varungandhi-src varungandhi-src Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the (not available on server)/is the above doc comment still accurate?


var (
ProvisioningCPUUsageLongTerm sharedObservable = func(containerName string, owner monitoring.ObservableOwner) Observable {
Expand Down Expand Up @@ -124,7 +124,7 @@ func NewProvisioningIndicatorsGroup(containerName string, owner monitoring.Obser
options = &ContainerProvisioningIndicatorsGroupOptions{}
}

title := TitleProvisioningIndicators
title := TitleResourceUtilization
if options.CustomTitle != "" {
title = options.CustomTitle
}
Expand Down
4 changes: 2 additions & 2 deletions monitoring/definitions/zoekt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,10 +1125,10 @@ func Zoekt() *monitoring.Dashboard {
}),

shared.NewProvisioningIndicatorsGroup(indexServerContainerName, monitoring.ObservableOwnerSearchCore, &shared.ContainerProvisioningIndicatorsGroupOptions{
CustomTitle: fmt.Sprintf("[%s] %s", indexServerContainerName, shared.TitleProvisioningIndicators),
CustomTitle: fmt.Sprintf("[%s] %s", indexServerContainerName, shared.TitleResourceUtilization),
}),
shared.NewProvisioningIndicatorsGroup(webserverContainerName, monitoring.ObservableOwnerSearchCore, &shared.ContainerProvisioningIndicatorsGroupOptions{
CustomTitle: fmt.Sprintf("[%s] %s", webserverContainerName, shared.TitleProvisioningIndicators),
CustomTitle: fmt.Sprintf("[%s] %s", webserverContainerName, shared.TitleResourceUtilization),
}),

shared.NewGolangMonitoringGroup(indexServerJob, monitoring.ObservableOwnerSearchCore, &shared.GolangMonitoringOptions{ContainerNameInTitle: true}),
Expand Down