Skip to content

Why does collect() silently ignore unexpected positional args? #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
timsnyder wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Why does collect() silently ignore unexpected positional args? #545

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb02dbe
Why does `collect()` silently ignore unexpected positional args?
timsnyder Dec 3, 2024
21a43b3
fix typo
timsnyder Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sparta/test/PEvents/PEventHelper_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ int main() {
trigger.go();
A a(1000, 78, 52, 0.01, "test0");
pair_pevent.collect(a);
EXPECT_THROW(pair_event.collect(a, "unexpected positional pair arg"));
Comment thread
timsnyder marked this conversation as resolved.
Outdated
pair_verbose_pevent.collect(a);
decode_pevent.collect(a);
my_pevent.collect(a, 32);
Expand Down