Skip to content

fix: support new clang-dumper template arguments - #241

Open
lm-sousa wants to merge 1 commit into
dumper-polish-cleanupfrom
dumper-polish-template-arguments
Open

fix: support new clang-dumper template arguments#241
lm-sousa wants to merge 1 commit into
dumper-polish-cleanupfrom
dumper-polish-template-arguments

Conversation

@lm-sousa

Copy link
Copy Markdown
Member

The future clang-dumper emits four template-argument kinds that Clava currently rejects.

This adds parser and AST support for Declaration, NullPtr, TemplateExpansion, and StructuralValue. The structural-value model keeps the serialized type; the current dumper does not serialize the value payload.

Verification:

  • gradle -p ClangAstParser compileJava
  • parsed the post-release template_expansion_pack.cpp corpus with a local build of clang-dumper and reparsed Clava's generated output

Model: GPT-5.6-Luna

Copilot AI lite review requested due to automatic review settings August 28, 2026 17:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d48196efd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lm-sousa
lm-sousa force-pushed the dumper-polish-template-arguments branch from 4d48196 to 6e393a1 Compare August 28, 2026 19:28
@lm-sousa
lm-sousa force-pushed the dumper-polish-template-arguments branch from 6e393a1 to 840aea4 Compare September 3, 2026 04:24
@sonarqubecloud

sonarqubecloud Bot commented Sep 3, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@lm-sousa
lm-sousa force-pushed the dumper-polish-template-arguments branch from 840aea4 to 107f009 Compare September 5, 2026 23:35
@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants