fix: support base components in offsetof expressions - #243
Open
lm-sousa wants to merge 7 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b3a7cd9d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lm-sousa
force-pushed
the
dumper-polish-offsetof-base
branch
from
August 28, 2026 19:28
6b3a7cd to
6d3e2f7
Compare
lm-sousa
force-pushed
the
dumper-polish-offsetof-base
branch
2 times, most recently
from
September 3, 2026 04:24
660ff17 to
9f3fd8b
Compare
|
lm-sousa
force-pushed
the
dumper-polish-offsetof-base
branch
from
September 5, 2026 23:37
884518e to
f1e6066
Compare
Read platform checks and manifest consumers through a stable cached manifest file (cuda/redistrib_<release>.json) installed with CacheFiles.installFile, mirroring ClangAstWebResource.getManifest, so repeated isBuiltinCudaSupported-style calls do not re-download the manifest. The staging-based manifest download remains for release installation only. Tests: CudaResourcesTest (17), ClangResourcesTest (27)
SYSTEM mode with built-in CUDA requires a matching system Clang resource directory for Clang's CUDA wrapper headers. Extend the failure message with the expected Clang command, install hints, and the 'builtin' libc mode alternative so users can self-serve. The command and version in the message are derived from the dumper's LLVM major at runtime; the 'apt install clang++-18' wording users actually see is just an example of the rendered output. Tests: CudaResourcesTest (17), ClangResourcesTest (27)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The future clang-dumper emits
Basecomponents foroffsetofexpressions, but Clava currently rejects that component kind.This adds an
OffsetOfBasemodel and parses its serialized base type so nested-base member paths remain available to Clava.Verification:
gradle -p ClangAstParser compileJavagit diff --checkModel: GPT-5.6-Luna