Lang spec v3 - #244
Open
lm-sousa wants to merge 17 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7466f14582
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… generator. This is a massive (but imcomplete) commit. - Replaced the old XML-based Language Specification with the new Java embedded-DSL one. - Updated joinpoint concrete classes to extend their respective abstract classes with a generic CRTP pattern Self type parameter. - Simplified concrete types by having a single direct class hierarchy enforced by the generator. - Concretes no longer declare the node field. That is done in the basae abstract jp in LARA. - Refactored methods to use getNodeImpl() for consistency in accessing underlying AST nodes. - Updated ClavaDirective and ClavaPragmas to use the new AJoinpoint interface. - Adjusted ClavaAstMethods to accommodate changes in JoinPoint interface.
…rchy and the generator.
…vaException import
…ing' from actions into attributes.
… to escape forbidden Java keywords.
… a few type casting problems. They warrant further analysis.
The langSpecV3 migration mapped the original binaryOp("=") to OpKind.eq
(comparison) instead of OpKind.assign, so outlining generated *result ==
retVal and *retFlag == 1 instead of assignments. The caller never observed
the outlined return value nor the success flag.
…tion switches The InsertPosition enum never contained around; these legacy string fall-throughs were the only remaining paths that accepted it, behaving identically to replace. Any script passing the raw string now fails loudly instead of silently aliasing replace.
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.