Skip to content

Use gomplate to template Dockerfiles#103

Merged
Ilyes512 merged 2 commits into
mainfrom
use-templating
Jun 25, 2026
Merged

Use gomplate to template Dockerfiles#103
Ilyes512 merged 2 commits into
mainfrom
use-templating

Conversation

@Ilyes512

Copy link
Copy Markdown
Member

Summary

  • Add Dockerfile.tmpl as the single source of truth for all three variant Dockerfiles
  • Add variants/{fpm,apache,frankenphp}.yaml with static per-variant metadata (label, doc URL, frankenphp flag) — base image tag is never stored here
  • Add task generate (runs gomplate via Docker) and task install:hooks / task remove:hooks for the pre-commit hook
  • Wire a template-check job into the PR workflow so build only runs after check confirms the committed Dockerfiles match the template output

Test plan

  • task generate produces no diff against the committed Dockerfiles
  • Edit Dockerfile.tmpl, run task generate, confirm change appears in all three Dockerfiles
  • CI check job passes on this PR

@Ilyes512 Ilyes512 merged commit 14a148f into main Jun 25, 2026
10 checks passed
@Ilyes512 Ilyes512 deleted the use-templating branch June 25, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant