QA fix: regenerate psalm baseline, bump rector to ~2.4.5 and re-run it, apply cs fix#1258
Merged
Conversation
samsonasik
changed the title
Contributor
Author
|
@roxblnfk ready to merge 👍 |
Member
|
These psalm issues will be fixed with vimeo/psalm#11866 |
Contributor
Author
|
@roxblnfk I think ignore error is fine for now to keep moving forward, then clean up later once fix applied to psalm. |
roxblnfk
approved these changes
Jun 5, 2026
Member
I agree. Just moved them into baseline file. Thanks for contribution and highlighting codebase issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Some rector rules skipped for now for easier to review. Can be gradually applied.
Why?
Make Static analysis workflow green.
Checklist