Add configuration property for leaveGroupOnClose in Kafka Streams#50432
Open
taasjord wants to merge 1 commit into
Open
Add configuration property for leaveGroupOnClose in Kafka Streams#50432taasjord wants to merge 1 commit into
taasjord wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: enhancement
taasjord
force-pushed
the
leave-group-on-close-prop
branch
from
2f17afd to
4c75fa1
Compare
This makes it possible to set the option to leave the group on close at configuration/deployment time in the application properties. Signed-off-by: Trygve Aasjord <taasjord@users.noreply.github.com>
taasjord
force-pushed
the
leave-group-on-close-prop
branch
from
4c75fa1 to
11ab2d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the option to leave the group on close in Kafka Streams is often a deployment time concern rather than at build time, eg. for rolling deployments in Kubernetes.
Earlier there was a "internal.leave.group.on.close" property in Kafka Streams, but this has been removed and been replaced by API option in
KafkaStreams.closethat theStreamsBuilderFactoryBeanuses, but could only by set withStreamsBuilderFactoryBean.setLeaveGroupOnClose(true)in code.This change makes it possible again to set the option to leave the group on close at configuration/deployment time using the application properties:
The default is
false, which is the same asStreamsBuilderFactoryBean.leaveGroupOnClosedefault, so there should be no change in behaviour unless the property is explicitly set.