Skip to content
This repository was archived by the owner on May 22, 2019. It is now read-only.

Fix a missing argument (series) to the call of the save function #399

Open
Jan21 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix a missing argument (series) to the call of the save function #399

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3b6e7e
Fix a missing argument (series) to the call of the save function
JanHula Mar 29, 2019
2321c27
Fix a missing argument (series) to the call of the save function
JanHula Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sourced/ml/transformers/bow_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def __call__(self, head: RDD):
filename = self.get_bow_file_name(self.filename, i)
BOW() \
.construct(docs, tokens, matrix) \
.save(filename, deps=(self.df,))
.save(filename, series="Bow", deps=(self.df,))
Copy link
Copy Markdown
Collaborator

@vmarkovtsev vmarkovtsev Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should require "series" argument in __init__, because BowWriter is an implementation of writing the model and it cannot know the specific from the inside.

self._log.info("%d -> %s with %d documents, %d nnz (%s)",
i + 1, filename, len(docs), size,
humanize.naturalsize(os.path.getsize(filename)))
Expand Down