Repository navigation
Conversation
Open
1 task
iurii-ssv
added this pull request to stack #3095
October 7, 2026 11:11
iurii-ssv
removed this pull request from stack #3095
October 7, 2026 11:11
iurii-ssv
added this pull request to stack #3096
October 7, 2026 11:12
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
momosh-ssv
previously approved these changes
Oct 8, 2026
iurii-ssv
dismissed
momosh-ssv’s stale review
October 13, 2026 13:08
The merge-base changed after approval.
momosh-ssv
removed this pull request from stack #3096
October 15, 2026 07:36
Clears all five grpc advisories reported against v1.79.1 (GO-2026-4762,
GO-2026-6061, GO-2026-6348, GO-2026-6441, GO-2026-6443). grpc is only
pulled in by the OTel OTLP gRPC exporters (traces are opt-in), so this
is low urgency, but it keeps scanners quiet.
MVS also raises golang.org/x/{crypto,net,text,mod,sync,term,tools,
telemetry}, genproto and gonum. x/net 0.58.0 additionally clears
GO-2026-5025..5030 and GO-2026-5942, x/crypto 0.55.0 clears GO-2026-6303.
Needs otel/sdk >= v1.44.0 together with a matching semconv import, which
the parent PR already provides (otel v1.45.0 + semconv v1.43.0); bumping
grpc on its own on top of otel v1.41.0 makes buildResources fail with a
schema URL conflict at startup.
momosh-ssv
force-pushed
the
deps/grpc-1.83.2
branch
from
October 15, 2026 07:40
50d6594 to
3ba8990
Compare
momosh-ssv
added this pull request to stack #3123
October 15, 2026 07:40
momosh-ssv
approved these changes
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3071.
Bumps
google.golang.org/grpcv1.79.1 → v1.83.2, the first version that clears every grpc advisory reported against v1.79.1:/in:path:authority/Hostare missingv1.84.0 contains the same fixes, but the Go vuln DB still lists it as affected by GO-2026-6443, so
govulncheckwould keep flagging it. v1.83.2 is clean in both the Go DB and GHSA.Exposure
grpc is only an indirect dependency, pulled in by the OTel OTLP gRPC exporters. Tracing is opt-in (
EnableTraces), and the other end is the operator's own collector. Most of these advisories affect gRPC servers (xDS, HTTP/2 server), which we don't run. So this is low urgency, mainly to keep scanners quiet.Why stacked on #3071
grpc v1.83.x requires otel/sdk ≥ v1.44.0. Without #3071's matching
semconvmove,resource.Default()switches to schema 1.41.0 whileobservability/resources.gostays on semconv v1.39.0, andbuildResourcesfails at startup withconflicting Schema URL(the #3020 failure mode). On top of #3071 (otel v1.45.0 + semconv v1.43.0),go getchanges nothing in OTel.Side effects (MVS)
golang.org/x/{crypto 0.55.0, net 0.58.0, text 0.41.0, mod, sync, term, tools, telemetry}, genproto and gonum. Bonus: x/net 0.58.0 clears GO-2026-5025..5030 and GO-2026-5942, and x/crypto 0.55.0 clears GO-2026-6303. Those are still open on #3071's x/net 0.54.0 / x/crypto 0.52.0. Only
go.mod/go.sumchange, no code changes.Verification
go mod tidymakes no further changes (root and ssvsigner); build and vet pass.observability/...tests pass, includingTestBuildResourcesandTestInitializeProvider_MeasurementReachesScrapefrom deps: security bumps (x/crypto, otel/sdk, chi) #3071.golangci-lint and the root unit tests pass on top of the follow-up PR stacked on this one, which is a superset of this change. The exceptions are three mDNS-based network tests, which fail the same way on unmodified
stagein my local sandbox; CI covers those.E2E passed - [action log](put link here)