Skip to content

chore: Bump Rust edition to 2024#789

Merged
Techassi merged 1 commit into
stackabletech:mainfrom
Saul-STFC:rust-2024-upgrade
Jun 8, 2026
Merged

chore: Bump Rust edition to 2024#789
Techassi merged 1 commit into
stackabletech:mainfrom
Saul-STFC:rust-2024-upgrade

Conversation

@Saul-STFC
Copy link
Copy Markdown
Contributor

Run cargo fix --edition:

  • Fix Rust 2024 temporary drop order change in tail expression by adding a trailing semicolon to the controller match block in hdfs_clusterrolebinding_nodes_controller.rs
  • Add use<> (auto refactor by cargo fix) Clippy refactor:
  • Simplify nested conditions

Part of stackabletech/issues#832

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Run `cargo fix --edition`:

- Fix Rust 2024 temporary drop order change in tail expression by adding a trailing semicolon to the controller match block in hdfs_clusterrolebinding_nodes_controller.rs
- Add use<> (auto refactor by cargo fix)
Clippy refactor:
- Simplify nested conditions
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 3, 2026
@Techassi Techassi changed the title chore: bump Rust edition to 2024 and apply cargo fix + clippy updates chore: Bump Rust edition to 2024 Jun 8, 2026
@Techassi Techassi added this pull request to the merge queue Jun 8, 2026
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Jun 8, 2026
Merged via the queue into stackabletech:main with commit 5470eef Jun 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

4 participants