feat: add validating admission webhooks for Ingress and IngressClass annotations#1119
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6761736 to
54c68e1
Compare
9527e83 to
433aa12
Compare
bb3d993 to
521ae2d
Compare
|
When the webhook pod runs with hostNetwork: false, the API server times out trying to reach it (context deadline exceeded). It works fine when hostNetwork is set to true. Should we stick with hostNetwork: true as a workaround, or is there a preferred way to enable API-server-to-Pod routing for webhooks in SKE? |
521ae2d to
ababbcc
Compare
ababbcc to
7fd1cc2
Compare
7fd1cc2 to
cc567ab
Compare
cc567ab to
51071c5
Compare
|
@kamilprzybyl: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
This PR introduces two separate Validating Admission Webhooks for the STACKIT ALB controller to enforce constraints, formatting, and allowed values on ALB annotations.
By failing fast at the Kubernetes API level, this prevents invalid configurations from being created in the cluster if they do not meet the ALB controller's requirements.