refac(opensearch): Use new WaitHelper for waiters#7323
Open
Fyusel wants to merge 1 commit into
Open
Conversation
STACKITSDK-385 Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
7985eea to
d1f8909
Compare
rubenhoenle
reviewed
May 19, 2026
| @@ -27,44 +28,44 @@ const ( | |||
|
|
|||
| // CreateInstanceWaitHandler will wait for instance creation | |||
| func CreateInstanceWaitHandler(ctx context.Context, a opensearch.DefaultAPI, projectId, instanceId string) *wait.AsyncActionHandler[opensearch.Instance] { | |||
Member
There was a problem hiding this comment.
Could be half the code 😉
// note the private visibility for the shared logic
func createOrUpdateInstanceWaitHandler(ctx context.Context, a opensearch.DefaultAPI, projectId, instanceId string) *wait.AsyncActionHandler[opensearch.Instance] {
waitConfig := wait.WaiterHelper[opensearch.Instance, string]{
FetchInstance: a.GetInstance(ctx, projectId, instanceId).Execute,
GetState: func(s *opensearch.Instance) (string, error) {
if s == nil {
return "", errors.New("empty response")
}
if s.Status == nil {
return "", errors.New("status is missing")
}
return *s.Status, nil
},
ActiveState: []string{INSTANCESTATUS_ACTIVE},
ErrorState: []string{INSTANCESTATUS_FAILED},
}
handler := wait.New(waitConfig.Wait())
handler.SetTimeout(45 * time.Minute)
return handler
}
func CreateInstanceWaitHandler(ctx context.Context, a opensearch.DefaultAPI, projectId, instanceId string) *wait.AsyncActionHandler[opensearch.Instance] {
return createOrUpdateInstanceWaitHandler(...)
}
func PartialUpdateInstanceWaitHandler(ctx context.Context, a opensearch.DefaultAPI, projectId, instanceId string) *wait.AsyncActionHandler[opensearch.Instance] {
return createOrUpdateInstanceWaitHandler(...)
}You can then also use the test construct I've shown @GokceGK here to test all 3 implementations using the same logic:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKITSDK-385
Description
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)