Skip to content

fix(secretsmanager): remove RequiresReplace for secretsmanager description#1495

Open
j1n-o9r wants to merge 2 commits into
mainfrom
fix/STACKITTPR-649-secretsmanager-inplace-update-user-description
Open

fix(secretsmanager): remove RequiresReplace for secretsmanager description#1495
j1n-o9r wants to merge 2 commits into
mainfrom
fix/STACKITTPR-649-secretsmanager-inplace-update-user-description

Conversation

@j1n-o9r
Copy link
Copy Markdown
Contributor

@j1n-o9r j1n-o9r commented Jun 1, 2026

Description

Change in the secretsmanager description triggers unnecessary replacement of resource.

relates to STACKITTPR-649 and #882

Testing Instructions

Acceptance tests are currently blocked by STACKITSMA-1012, therefore you must test it manually:

resource "stackit_secretsmanager_instance" "example" {
  project_id = local.project_id
  name       = "example-name"
}

resource "stackit_secretsmanager_user" "example" {
  project_id    = local.project_id
  instance_id   = stackit_secretsmanager_instance.example.instance_id
  description   = ""
  write_enabled = false
}

run terraform apply and approve -> the instance and the user should be created. Then change the user resource:

resource "stackit_secretsmanager_user" "example" {
  project_id    = local.project_id
  instance_id   = stackit_secretsmanager_instance.example.instance_id
  description   = "example"
  write_enabled = false
}

run terraform apply -> tf should suggest an inplace update for the user.

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@j1n-o9r j1n-o9r changed the title fix(secretsmanager): remove RequiresReplace for secretsmanager descri… fix(secretsmanager): remove RequiresReplace for secretsmanager description Jun 1, 2026
@j1n-o9r j1n-o9r force-pushed the fix/STACKITTPR-649-secretsmanager-inplace-update-user-description branch from 2516be2 to 42f683f Compare June 1, 2026 11:43
@j1n-o9r j1n-o9r force-pushed the fix/STACKITTPR-649-secretsmanager-inplace-update-user-description branch from 42f683f to b2a94ef Compare June 1, 2026 11:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/user 16.14% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/user/resource.go 13.10% (ø) 168 22 146

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/secretsmanager/user/resource_test.go

@j1n-o9r j1n-o9r marked this pull request as ready for review June 1, 2026 12:03
@j1n-o9r j1n-o9r requested a review from a team as a code owner June 1, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant