Xvideos: harden fragment ID extraction and fallback#2735
Open
smegmarip wants to merge 1 commit into
Open
Conversation
Changes:
- Add numeric-leading JDownloader filename rule: ^([0-9]{6,11})_.+ -> $1.
- Keep alphanumeric-leading rule separate and dot-prefixed: ^([a-z0-9]{6,11})_.+ -> .$1.
- Preserve yt-dlp bracketed ID rule with dot-prefixed replacement.
- Tighten fallback extension cleanup to probable extensions only: (?i).*\.[a-z0-9]{1,5}$ -> .
- Update scraper timestamp comment to May 6, 2026.
Risks / assumptions:
- ID lower bound remains 6 for compatibility with existing plugin behavior.
- Numeric and alphanumeric collision handling depends on rule order (numeric rule intentionally first).
- Unknown filename formats that miss all ID rules still fall back to video./x behavior (pre-existing).
- If very short dot-suffix IDs (<=5) exist in the future, fallback may treat them as extensions.
smegmarip
referenced
this pull request
May 6, 2026
Member
then add it to the previous regexes. |
Contributor
Author
If I do, then non-matches will pass the entire input filename to the xvideo api. Are you ok with that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Risks / assumptions:
Generated by an automatic template. Can be removed if not applicable.
Scraper type(s)
Examples to test
30107781_culona en el gym perfecta.mp4
24205607_culo gym.mp4
uukvteb9147_Young Fashion Model Turned Humiliated Bondage Slave.mp4
Short description
Describe the general changes