Feature/Fix: Run lineage accounting in shadow mode#2144
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 13, 2026, 9:19 PM ET / July 14, 2026, 01:19 UTC. Summary Reproducibility: yes. at the source level: the canonical issue and merged sanitized fork-family fixtures establish the overcount shape and need for cross-file lineage accounting. This PR lacks a new live affected-corpus run for its shadow pipeline. (github.com) Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Close this PR as superseded by #2082. Do we have a high-confidence way to reproduce the issue? Yes at the source level: the canonical issue and merged sanitized fork-family fixtures establish the overcount shape and need for cross-file lineage accounting. This PR lacks a new live affected-corpus run for its shadow pipeline. (github.com) Is this the best way to solve the issue? Unclear as submitted. A shadow-first rollout is maintainable, but unconditional refresh integration and the parser-hash change need prerequisite isolation and live initial/repeat-scan proof before this is established as the best landing shape. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 0437067deaa8. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Superseded by the consolidated four-PR review stack. This slice is now included in #2156; closing this draft to keep the upstream review surface manageable. |
Stack dependency
This is slice 5 of 15. It follows Feature/Fix: Preserve lineage accounting dimensions; review and merge that PR first.
Summary
This is the fifth isolated component of the planned Codex scanner rearchitecture. The legacy scanner remains authoritative.
Validation
swift test --filter CodexLineageShadowTestsmake checkenv SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.5.sdk make test(641 selections)Related investigation: steipete/CodexBar#2037.