Feature/Fix: Diagnose Codex reset-epoch token collisions#2152
Feature/Fix: Diagnose Codex reset-epoch token collisions#2152iam-brain wants to merge 13 commits into
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 13, 2026, 9:21 PM ET / July 14, 2026, 01:21 UTC. Summary Reproducibility: yes. for the diagnostic behavior: focused tests define the reset-and-repeat path, and the PR reports a frozen-history replay that found same-document candidates. That replay also shows this theory does not reproduce the remaining July 9 undercount. Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Keep legacy accounting authoritative by default, land the lineage slices in dependency order, and retain this analyzer as aggregate-only shadow evidence unless later promotion work independently proves accounting correctness and upgrade safety. Do we have a high-confidence way to reproduce the issue? Yes for the diagnostic behavior: focused tests define the reset-and-repeat path, and the PR reports a frozen-history replay that found same-document candidates. That replay also shows this theory does not reproduce the remaining July 9 undercount. Is this the best way to solve the issue? Yes for diagnosis: a pure shadow analyzer with aggregate-only output is safer and narrower than changing selected totals from speculative collision evidence. Merge review should occur after the predecessor lands so the diagnostic-specific diff can be evaluated independently. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 0437067deaa8. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Superseded by the consolidated four-PR review stack. This slice is now included in #2158; closing this draft to keep the upstream review surface manageable. |
Stack dependency
This is slice 13 of 15. It follows Feature/Fix: Validate lineage accounting on frozen local histories; review and merge that PR first.
Summary
Real-world result
This does not explain the remaining July 9 undercount. The frozen corpus produced zero reset-epoch candidate tokens on July 9.
Across the wider replay, 97 same-document repeats represented about 16.3M counterfactual tokens: roughly 7.3M on July 10 and 6.2M on July 11. Cross-owner detection produced 96,008 candidates and a clearly implausible estimate dominated by copied fork history, confirming that it is diagnostic evidence rather than a safe accounting rule.
Selected totals remain unchanged.
Tests
make checkmake test(648 selections in 54 groups; one group timed out under concurrent SwiftPM contention and all 12 isolated selections recovered; command passed)Related investigation: steipete/CodexBar#2037.