Improve DeepSeek detailed usage#2216
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 16, 2026, 9:15 AM ET / 13:15 UTC. Summary Reproducibility: not applicable. This PR adds and extends DeepSeek authentication and usage capabilities rather than fixing a clearly reproduced current-main bug. The relevant review path is fresh-install, upgrade, and real browser-session validation. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Land one canonical DeepSeek branch that keeps newly imported Chrome tokens ephemeral, explicitly documents or migrates legacy stored tokens, and includes redacted live proof for no-API-key balance plus multi-profile account isolation before closing the overlapping PR. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR adds and extends DeepSeek authentication and usage capabilities rather than fixing a clearly reproduced current-main bug. The relevant review path is fresh-install, upgrade, and real browser-session validation. Is this the best way to solve the issue? Unclear: the defensive fetch design and profile-scoping tests are strong, but the permanent legacy-token persistence boundary and which overlapping PR should land require maintainer confirmation. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 6d71af30b84d. Label changesLabel changes:
Label justifications:
Evidence reviewedSecurity concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
|
Thanks @joeVenner for carrying this work forward and validating it. PR #2135 contains Zihao-Qi’s original DeepSeek commits and is being merged as the canonical change so first-author credit stays intact. The additional UsageFetcher+Testing.swift split is useful; please send that focused refactor as its own small PR. |
Summary
Verification