udiskslinuxfilesystem: Fix TOCTOU race in mount point directory creation - #1515
Merged
tbzatek merged 1 commit intoAug 27, 2026
Merged
Conversation
tbzatek
reviewed
Aug 26, 2026
tbzatek
left a comment
tbzatek
left a comment
Member
There was a problem hiding this comment.
Sounds good and less racy, thanks! Please just rebase your branch.
Rename calculate_mount_point() to create_mount_point() and move the g_mkdir(2) call inside the uniquification loop. Using mkdir(2) as the existence check instead of g_file_test() + a separate mkdir(2) closes the window where two concurrent mount requests could compute the same candidate path and both succeed the test before either creates the directory. On failure after the directory is already created, callers now call g_rmdir() to release the reserved directory before returning an error. Fixes: storaged-project#1513 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ajax-semenko-d
force-pushed
the
master_mounting-toctou-fix
branch
from
August 27, 2026 08:29
31f9c0c to
d0379bf
Compare
|
Cockpit tests failed for commit d0379bf. @martinpitt, @jelly, @mvollmer please check. |
Contributor
|
The rawhide tests fail on some mirror issue, so likely have to be retried: |
Member
I've noticed more Testing Farm breakage yesterday, looks like infra issues - unrelated, ignoring. |
Member
|
Jenkins, ok to test. |
tbzatek
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename calculate_mount_point() to create_mount_point() and move the g_mkdir(2) call inside the uniquification loop. Using mkdir(2) as the existence check instead of g_file_test() + a separate mkdir(2) closes the window where two concurrent mount requests could compute the same candidate path and both succeed the test before either creates the directory.
On failure after the directory is already created, callers now call g_rmdir() to release the reserved directory before returning an error.
Fixes: #1513