feat: add append mode to file_write tool#493
Open
xlyoung wants to merge 1 commit into
Open
Conversation
Add optional 'mode' parameter to file_write tool that allows appending content to existing files instead of always overwriting. - mode='w' (default): overwrite file (existing behavior) - mode='a': append content to existing file The documentation at strandsagents.com claims append mode is supported, but the implementation hardcoded open(path, 'w'). This fix aligns the implementation with the documented behavior. Fixes strands-agents#344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
file_writetool hardcodesopen(path, 'w'), always overwriting the file. The documentation at strandsagents.com claims append mode is supported, but the implementation doesn't support it.Fix
Add optional
modeparameter tofile_write:mode='w'(default): overwrite file — existing behavior preservedmode='a': append content to existing fileChanges
modeparameter with enum['w', 'a']and default'w'modefrom tool input, use it inopen(path, mode)Testing
All 9 file_write tests pass with no changes needed.
Fixes #344