Repository navigation
fix: Disable turns off Dutch, Persian and Spanish when the language was added without its region - #1772
Merged
Conversation
…as added without its region Disable removed only nl-NL, fa-IR and es-ES, to leave Flemish, Dari and other Spanish variants on. cspell-dicts has no dictionary for any of them, so a user who had added nl, fa or es couldn't turn the language off. Disable now also removes the bare tag, as for the other single-region languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For users: if you turned Dutch, Persian or Spanish on with the bare language code (
nl,faoresincSpell.language), the extension's Disable command now turns it off.nl-NL,fa-IR,es-ES), so other variants of the language would stay on: Flemish (nl-BE), Dari (fa-AF) and other Spanish variants. cspell-dicts has no dictionary for any of them. The onlynl,faandesdictionaries are@cspell/dict-nl-nl,@cspell/dict-fa-irand@cspell/dict-es-es.nl-NL,nl,fa-IR,faandes-ES,es, as Swedish (sv-SE,sv) and the other single-region languages already do. Spanish's legacy Disable commands get the same values.notesexplained the narrow Disable, so they're removed.