coop: validate blueprint node references#1739
Open
tomelm wants to merge 1 commit into
Open
Conversation
6d2624e to
c4f8cfb
Compare
a53d18a to
0b3e587
Compare
0b3e587 to
164e376
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${node.<step>.<node>...}references when a blueprint is loaded (LoadBlueprint), so malformed or unknown node references fail fast instead of surfacing as confusing errors mid-session.step.node(andstep.node.request) keys, then check every${node...}reference in the marshaled blueprint against them.Tests
TestValidateBlueprintReferences— covers valid references, malformed references, and unknown referenced nodes.go test ./pkg/coop/... ./pkg/cmd/coop/...— all green.Base
Based directly on
coop. First of the co-op product-quality follow-ups;agent-qualityandblueprint-schemabuild on top and will be opened ascoopadvances.