[stripe agent setup] Surface skills status in setup flows#1757
Merged
Conversation
gusnguyen-stripe
changed the title
Compare installed skill files against the remote index by SHA256 hash, with parallel remote fetches capped for docs.stripe.com requests. Co-authored-by: Cursor <cursoragent@cursor.com> Committed-By-Agent: cursor
gusnguyen-stripe
force-pushed
the
gusnguyen/agent-setup-skills-status
branch
from
679486a to
ac5e3aa
Compare
gusnguyen-stripe
force-pushed
the
gusnguyen/update-skills
branch
from
01057ab to
05d7e9d
Compare
Collapse partial into out_of_date at the source so no downstream code reasons about a state the CLI never surfaces. Co-authored-by: Cursor <cursoragent@cursor.com> Committed-By-Agent: cursor
gusnguyen-stripe
force-pushed
the
gusnguyen/agent-setup-skills-status
branch
from
ac5e3aa to
6844551
Compare
jleong-stripe
approved these changes
Jul 9, 2026
vcheung-stripe
approved these changes
Jul 9, 2026
Answers review feedback: on a per-file fetch failure we intentionally bias toward update (idempotent, non-destructive) rather than reporting the skill as current, which could hide real drift. Co-authored-by: Cursor <cursoragent@cursor.com> Committed-By-Agent: cursor
gusnguyen-stripe
force-pushed
the
gusnguyen/agent-setup-skills-status
branch
from
1e3049f to
07f0f0d
Compare
Each file-check goroutine records its result in outcomes and always returns nil, so the errgroup error is intentionally discarded. Co-authored-by: Cursor <cursoragent@cursor.com> Committed-By-Agent: cursor
Show local and global skills state in --status, --json, and the interactive TUI, and support updating already-installed skills. Co-authored-by: Cursor <cursoragent@cursor.com> Committed-By-Agent: cursor
Follows the removal of the partial status: simplify skillsScopeNeedsUpdate and the status renderers, and delete skillsNeedsAction/skillsScopeNeedsAction which had no call sites. Co-authored-by: Cursor <cursoragent@cursor.com> Committed-By-Agent: cursor
Co-authored-by: Cursor <cursoragent@cursor.com> Committed-By-Agent: cursor
gusnguyen-stripe
force-pushed
the
gusnguyen/agent-setup-skills-status
branch
from
07f0f0d to
4e2215b
Compare
gusnguyen-stripe
added a commit
that referenced
this pull request
Jul 9, 2026
### Reviewers r? @jleong-stripe cc @stripe/developer-products ### Summary Refines when and how `stripe agent setup` fetches skills status so plugin-only non-interactive paths stay fast, errors fail open, and plugin status takes priority in `--status` output. ### What it does **Plugin-only paths** — keeps non-interactive plugin setup independent from skills checks: - `stripe agent setup --client <id>` does not fetch skills status - Calling-agent plugin setup does not fetch skills status (optimize for latency) - `--status`, `--json`, and interactive mode still fetch skills status because they display it **Fail open** — skills check errors do not block status or TUI flows; errors are surfaced in output instead of aborting setup. **Status ordering** — when agents are detected, `--status` shows plugin status before skills status. ### Stack PR 3 of 4. Depends on #1757. --- <sub>Stack created with <a href="https://github.com/github/gh-stack">GitHub Stacks CLI</a> • <a href="https://gh.io/stacks-feedback">Give Feedback 💬</a></sub> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @jleong-stripe
cc @stripe/developer-products
Summary
Wires
agentskills.Check()intostripe agent setupso skills status appears in--status,--json, and the interactive TUI, and supports updating already-installed skills.What it does
Skills status — adds local and global skills checks for flows that display skills:
--statusshows installation state (but hide the other one to discourage installing in both)--jsonincludes skills status and planned skills actionsSkills update flow — uses freshness checks before installing:
--forceis passedinstallSkillsfor JSON outputInteractive TUI — improves skills presentation for humans at a terminal:
Stack
PR 2 of 4. Depends on #1749.
Stack created with GitHub Stacks CLI • Give Feedback 💬