Fix curl install test: use POSIX-compatible set flags#1761
Open
yahanxing-stripe wants to merge 1 commit into
Open
Fix curl install test: use POSIX-compatible set flags#1761yahanxing-stripe wants to merge 1 commit into
yahanxing-stripe wants to merge 1 commit into
Conversation
The install script used `set -euo pipefail` under `#!/bin/sh`, but `pipefail` is a bash extension unsupported by dash (Ubuntu's /bin/sh), causing the CI job to exit with code 2. Switch to `set -eu` which is POSIX-compliant. Also initialize NEEDS_SOURCE=false to prevent unset variable errors under `set -u`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -euo pipefailwithset -euinscripts/install.sh—pipefailis a bash extension unsupported bydash(Ubuntu's/bin/sh), which caused thecurl-install-linuxCI job to exit with code 2NEEDS_SOURCE=falseto prevent unset variable errors underset -ucurl-install-test.ymlworkflow (removed by the revert in Revert "Add CI workflow for curl-based install script" #1755)Test plan
curl-install-test.ymlvia workflow_dispatch after mergecurl-install-linuxandcurl-install-macosjobs passsh scripts/install.shcompletes without errors on macOS🤖 Generated with Claude Code