Skip to content

Hooks: Preserve the activity-type registry during insertion. - #66

Merged
JJJ merged 1 commit into
masterfrom
fix/activity-action-registry
Oct 6, 2026
Merged

JJJ merged 1 commit into
masterfrom
fix/activity-action-registry

Conversation

@JJJ

@JJJ JJJ commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep the registered activity-type instances in their existing global registry during activity insertion
  • store temporarily removed WordPress callbacks in a dedicated suspended-actions global
  • preserve the existing remove and restore helper signatures and behavior
  • add regression coverage across repeated insertions in the same request

Validation

  • PHPUnit
  • PHPCS baseline
  • PHPStan
  • Composer validation and dependency audit
  • PHP syntax on 7.4, 8.0, 8.2, and 8.4
  • pinned metadata, manifest, integration-policy, and production artifact validation

Fixes #64.

Store temporarily removed WordPress callbacks in a dedicated suspended-actions global so activity insertion no longer replaces registered activity-type instances.

Add regression coverage across repeated insertions.

Fixes #64.
@JJJ
JJJ marked this pull request as ready for review October 6, 2026 09:36
Copilot AI balanced review requested due to automatic review settings October 6, 2026 09:36
@JJJ
JJJ merged commit 972d6d8 into master Oct 6, 2026
12 checks passed
@JJJ
JJJ deleted the fix/activity-action-registry branch October 6, 2026 09:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Activity insertion overwrites the activity-type registry

2 participants