-
Notifications
You must be signed in to change notification settings - Fork 16
[sophora-ugc] [sophora-ugc-proxy] add ServiceMonitors #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mlautzas
wants to merge
17
commits into
main
Choose a base branch
from
SUCI-615-add-prometheus-to-UGC
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2c2f3ba
[ugc] add ServiceMonitor objects for UGC and UGC multimedia
mlautzas 4738e3c
[ugc-proxy] add ServiceMonitor
mlautzas cb9261c
[ugc] add per service config for serviceMonitor and remove management…
mlautzas 448729e
[ugc] rename "jolokia" service to "management" across chart files
mlautzas 7b934b7
[ugc] allow monitoring via management service
mlautzas 8a7e1fa
[ugc] deploy ServiceMonitor only if UGC multimedia is enabled
mlautzas 5072259
[ugc] add health probes configuration
mlautzas 5aac2da
[ugc] make management service optional and configure port
mlautzas fd1342e
[ugc] move gcp config to ugc and ugcMultimedia sections and make it a…
mlautzas f79a207
[ugc] refactor ServiceMonitor target selection
mlautzas 25eb490
[ugc] adjust gcp backend policy test
mlautzas 96e3332
[ugc] revert test changes to gcp health
mlautzas 7ea5772
[ugc] disable ServiceMonitor by default
mlautzas 2ed23f4
[ugc] move management service configuration to toplevel
mlautzas 9cc3f30
[ugc] improve docs
mlautzas 81ef015
[ugc] add changelog
mlautzas fa1a84f
Merge branch 'main' into SUCI-615-add-prometheus-to-UGC
mlautzas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| {{- if .Values.serviceMonitor.enabled -}} | ||
| {{- $fullName := include "sophora-ugc-proxy.fullname" . -}} | ||
| apiVersion: monitoring.coreos.com/v1 | ||
| kind: ServiceMonitor | ||
| metadata: | ||
| name: {{ $fullName }} | ||
| labels: {{- include "sophora-ugc-proxy.labels" . | nindent 8 }} | ||
| spec: | ||
| selector: | ||
| matchLabels: {{- include "sophora-ugc-proxy.selectorLabels" . | nindent 12 }} | ||
| endpoints: | ||
| - interval: {{ .Values.serviceMonitor.interval }} | ||
| port: http | ||
| path: {{ .Values.serviceMonitor.path }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| {{- if .Values.ugc.serviceMonitor.enabled -}} | ||
| {{- $fullName := include "sophora-ugc.fullname" . -}} | ||
| apiVersion: monitoring.coreos.com/v1 | ||
| kind: ServiceMonitor | ||
| metadata: | ||
| name: {{ $fullName }} | ||
| labels: {{- include "sophora-ugc.labels" . | nindent 8 }} | ||
| spec: | ||
| selector: | ||
| matchLabels: {{- include "sophora-ugc.selectorLabels" . | nindent 12 }} | ||
| endpoints: | ||
| - interval: {{ .Values.ugc.serviceMonitor.interval }} | ||
| port: http | ||
| path: {{ .Values.ugc.serviceMonitor.path }} | ||
|
DanielRaapDev marked this conversation as resolved.
|
||
| {{- end }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
charts/sophora-ugc/templates/ugc-multimedia/servicemonitor.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| {{- if .Values.ugcMultimedia.serviceMonitor.enabled -}} | ||
| {{- $fullName := include "sophora-ugc-multimedia.fullname" . -}} | ||
|
Copilot marked this conversation as resolved.
Outdated
|
||
| apiVersion: monitoring.coreos.com/v1 | ||
| kind: ServiceMonitor | ||
| metadata: | ||
| name: {{ $fullName }} | ||
| labels: {{- include "sophora-ugc-multimedia.labels" . | nindent 8 }} | ||
| spec: | ||
| selector: | ||
| matchLabels: {{- include "sophora-ugc-multimedia.selectorLabels" . | nindent 12 }} | ||
| endpoints: | ||
| - interval: {{ .Values.ugcMultimedia.serviceMonitor.interval }} | ||
| port: http | ||
| path: {{ .Values.ugcMultimedia.serviceMonitor.path }} | ||
| {{- end }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.