Fix XSS vulnerability in block label input#506
Open
karthik-dev56 wants to merge 1 commit intosugarlabs:masterfrom
Open
Fix XSS vulnerability in block label input#506karthik-dev56 wants to merge 1 commit intosugarlabs:masterfrom
karthik-dev56 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
- Apply HTML sanitization to number block labels using safetext() - Ensures consistent security across both text and number block inputs - Prevents injection of malicious JavaScript via block label editing - Resolves issue sugarlabs#505 The vulnerability allowed XSS attacks through unsanitized labelValue in number block innerHTML assignment. This fix extends the existing safetext() sanitization that was already applied to text blocks.
Member
|
I am a bit confused. It seems you are working from a very outdated branch. Can you rebase from current master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vulnerability allowed XSS attacks through unsanitized labelValue in number block innerHTML assignment. This fix extends the existing safetext() sanitization that was already applied to text blocks.