fix(cli): skip pg_dump in db pull when using pg-delta diff engine#5255
Draft
avallete wants to merge 6 commits into
Draft
fix(cli): skip pg_dump in db pull when using pg-delta diff engine#5255avallete wants to merge 6 commits into
avallete wants to merge 6 commits into
Conversation
Initial pulls under --diff-engine pg-delta were dumping the remote schema via pg_dump before running pg-delta. The dump-then-restore round-trip strips ownership information for objects the local postgres role cannot assume, so platform-managed objects (FDWs, wasm wrappers, system-owned ACLs) leak into the migration file and break \`supabase db reset\` (see CLI-1469, CLI-1470). pg-delta speaks pg_catalog directly via extractCatalog and the supabase integration filters platform objects by owner. Diffing against an empty shadow on initial pull yields a clean initial migration on its own, so dumpRemoteSchema is unnecessary on this path.
Coverage Report for CI Build 26248142775Warning No base build found for commit Coverage: 63.936%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Added documentation for testing local pg-delta builds in CONTRIBUTING.md, detailing the steps to publish local changes and configure the CLI to use a local npm registry. Updated the RunEdgeRuntimeScript function to accept additional options for handling npm registry configurations, allowing for scoped .npmrc files and environment variable forwarding. Introduced PgDeltaNpmRegistryOption to manage npm registry settings and added tests to ensure correct behavior. Refactored related functions to integrate these enhancements, improving the overall local development experience for pg-delta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial pulls under --diff-engine pg-delta were dumping the remote
schema via pg_dump before running pg-delta. The dump-then-restore
round-trip strips ownership information for objects the local postgres
role cannot assume, so platform-managed objects (FDWs, wasm wrappers,
system-owned ACLs) leak into the migration file and break
`supabase db reset` (see CLI-1469, CLI-1470).
pg-delta speaks pg_catalog directly via extractCatalog and the supabase
integration filters platform objects by owner. Diffing against an
empty shadow on initial pull yields a clean initial migration on its
own, so dumpRemoteSchema is unnecessary on this path.