Repository navigation
feat: add --tsc-rs flag to svelte-check - #3144
Open
bmdavis419 wants to merge 1 commit into
Open
bmdavis419 wants to merge 1 commit into
bmdavis419 wants to merge 1 commit into
Conversation
Use tsc-rs, a Rust port of the TypeScript 7 compiler, for TypeScript diagnostics. It works like `--tsgo`: it writes the transpiled Svelte files to disk, takes the same overlay tsconfig and can be combined with `--incremental` and `--watch`. It cannot be combined with `--tsgo` or `--tsgo-experimental-api`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: d1ce703 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
this should be probably changed to use tsrs by cloudflare/void0 now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--tsc-rsto svelte-check: run TypeScript diagnostics with tsc-rs, a Rust port of the TypeScript 7 compiler. Works exactly like--tsgo(same disk-overlay mode, combinable with--incrementaland--watch) — only the spawned compiler binary differs. Requirestsc-rsinstalled in the workspace.On a real SvelteKit app (62
.svelte+ 81.tsfiles),--tsc-rsproduced diagnostics identical to--tsgoand ran ~20% faster (warm--incremental: 1.30s vs 1.61s).Important files:
packages/svelte-check/src/options.ts--tsc-rsCLI flag.packages/svelte-check/src/index.ts--tsgoor--tsgo-experimental-api.packages/svelte-check/src/incremental.ts'tsc' | 'tsgo' | 'tsc-rs'; resolves thetsc-rsbinary from the workspace (clear install-hint error if missing). No output-parser changes — tsc-rs's--prettyoutput matches tsgo's.packages/svelte-check/test-sanity.js--tsc-rs, mirroring--tsgo(tsc-rsadded as a devDependency, same as@typescript/native-previewfor tsgo).Notes:
--tsc-rswhere--tsgoand the default mode don't report them. Left as engine behavior; mentioning in case you want it documented.Models used: implemented by Claude Opus 5.5 (
claude-opus-5-5), orchestrated and verified by muse-wonder-full-1.0 (Muse Code in T3 Code). Tests run locally: svelte-check sanity suite 15/15 on Svelte 4 and Svelte 5.