Repository navigation
fix: show inlay hints in scripts that come after other content - #3150
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 5472010 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2078.
Problem
Inlay hints are missing inside a
<script>tag when anything comes before it in the file, for example<svelte:options runes />, a comment, or the instance script above a module script.svelte2tsx moves the scripts before the template in the generated code. The inlay hint provider maps only the start and end of the requested range to the generated code, so the generated span skips the script that moved:
Fix
convertToTargetTextSpanalso maps the part of each script that is inside the requested range and widens the generated span to include it.Test plan
content-before-scriptandmodule-script-after-instance-scriptinlay hint fixtures.pnpm testinpackages/language-serverpasses (830 passing, 0 failing).tsc --noEmitandprettier --checkare clean.