Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 24de0e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3159
getAllSvelteFiles()returned the keys of the provider'sFileMap, which are lowercase on case-insensitive file systems. svelte-check reported the Svelte compiler and CSS diagnostics of every file under that lowercased path, and separately from the file's TS errors. It now returns the snapshots' own paths.Test: CI runs on Linux, where the keys keep their case. So the new test stubs
ts.sys.useCaseSensitiveFileNamestofalsewhile creating a provider for a one-file project withUpper.svelte, and checks the returned path; the stub is restored inafterEachtoo. It fails without the change. Rootpnpm testpasses.pnpm lintpasses with #3161's ignore rules; without them it fails on generated files afterpnpm test. On macOS, the reproduction from the issue reports both diagnostics undersrc/Warn.svelte, with 1 file with problems instead of 2.