Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 29abbc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3163
--tsgo/--incrementaldidn't emit components under symlinked directories, because thefindFileswalk doesn't descend into them, so the project in #3163 checked no files. During the overlay emission, links that lead out of the workspace are now followed, keeping the link's path (withSymlinks({ resolvePaths: false })).openAllDocuments) stays as chore: switch from fast-glob to fdir #2433 left it.includeor an import reaches only through such a link stays unchecked, as before.resolvePathsneeds fdir 6.3, and the symlink loop fixes are in 6.4, so the range goes to^6.4.6, which the lockfile already has.Known limitations (reproduced; how common they are is unknown):
includethat covers both, an error there is reported twice. The default mode reports it once.src -> ../sharedplusshared/alias -> ../shared-other), as before.Covering links inside the workspace and these cases needs a loop check that tells loops from aliases (likely in fdir) and de-duplication of the reported diagnostics that doesn't drop distinct ones. I'd like to agree on that direction before growing this PR.
Test:
test-sanity.jsmakes a temporary project whosesrclinks to a directory outside it (a junction on Windows) with a type error, and checks that--tsgoreports it. It fails on master. Rootpnpm testpasses.pnpm lintpasses with #3161's ignore rules; without them it fails on generated files afterpnpm test.