Repository navigation
fix: report a tsconfig parse error in incremental runs instead of an internal error - #3169
Open
GBra-4-669 wants to merge 1 commit into
Open
GBra-4-669 wants to merge 1 commit into
GBra-4-669 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 8b410c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed tsconfig with
--incrementalor--tsgoand a path that is not normalized gives an internalDebug Failureinstead of the parse error. Ordinary Windows paths hit it. So does any.or..segment.TypeScript asserts that the diagnostic name equals the normalized name of the file it parsed.
The overlay writer now passes the resolved real path as the name so the parse error points at the right file. For a path through a symlink that means it names the resolved file instead of the path you passed. The read still uses the original path so symlinks and
..resolve like before.New
testFailurecases assert exit 1, thesvelte-check failedline and the expected text:.segment..All of them fail before the compiler process starts. The crash cases fail in it.
Test plan:
node test-sanity.json Linux, Windows and macOS.Not tested: Windows
\\?\paths. Two language-server places hit the same assert:service.tsfor the default run,typescript-go/features/DiagnosticsProvider.tsfor--tsgo-experimental-api.