Apply parameterized test optimizations for Dictionary to KeyValuePairs.#1699
Merged
Conversation
…airs`. This change ensures that test authors who explicitly pass collections of type `KeyValuePairs<K, V>` as test arguments will get the same sort of optimizations as they would if they passed a `Dictionary<K, V>` instead. This change complements, but is not dependent on, #1627.
grynspan
added
performance
stmontgomery
approved these changes
May 1, 2026
2 tasks
grynspan
added a commit
that referenced
this pull request
May 1, 2026
In #1699 I added `__DictionaryLikeCollection` but I can just use `ExpressibleByDictionaryLiteral` for this purpose. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that test authors who explicitly pass collections of type
KeyValuePairs<K, V>as test arguments will get the same sort of optimizations as they would if they passed aDictionary<K, V>instead.This change complements, but is not dependent on, #1627.
Checklist: