Skip to content

Reduce key-path COW copies in Runner.Plan helpers #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inju2403 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

Reduce key-path COW copies in Runner.Plan helpers #1730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Sources/Testing/Running/Runner.Plan.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,11 @@ extension Runner.Plan {
private static func _recursivelySynthesizeSuites(in graph: inout Graph<String, Test?>, nameComponents: [String] = []) {
// The recursive function. This is a local function to simplify the initial
// call which does not need to pass the `sourceLocation:` inout argument.
func synthesizeSuites(in graph: inout Graph<String, Test?>, nameComponents: [String] = [], sourceLocation: inout SourceLocation?) {
func synthesizeSuites(in graph: inout Graph<String, Test?>, nameComponents: inout [String], sourceLocation: inout SourceLocation?) {
for (key, var childGraph) in graph.children {
synthesizeSuites(in: &childGraph, nameComponents: nameComponents + [key], sourceLocation: &sourceLocation)
nameComponents.append(key)
synthesizeSuites(in: &childGraph, nameComponents: &nameComponents, sourceLocation: &sourceLocation)
nameComponents.removeLast()
graph.children[key] = childGraph
}

Expand Down Expand Up @@ -231,8 +233,9 @@ extension Runner.Plan {
}
}

var nameComponents = nameComponents
var sourceLocation: SourceLocation?
synthesizeSuites(in: &graph, sourceLocation: &sourceLocation)
synthesizeSuites(in: &graph, nameComponents: &nameComponents, sourceLocation: &sourceLocation)
}

/// Given an array of tests, synthesize any containing suites that are not
Expand Down
Loading