Skip to content

Reuse the traversal key path in TestFilter's precomputed filter #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inju2403 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reuse the traversal key path in TestFilter's precomputed filter #1744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Sources/Testing/Running/Configuration.TestFilter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,18 +283,18 @@ extension Configuration.TestFilter.Operation {
case let .precomputed(selection, membership):
switch membership {
case .including:
return testGraph.mapValues { _, item in
return testGraph.mapValues { keyPath, item in
guard let item else {
return nil
}
return selection.contains(item.test) ? item : nil
return selection.contains(keyPath) ? item : nil
}
case .excluding:
return testGraph.mapValues { _, item in
return testGraph.mapValues { keyPath, item in
guard let item else {
return nil
}
return !selection.contains(item.test, inferAncestors: false) ? item : nil
return !selection.contains(keyPath, inferAncestors: false) ? item : nil
}
}
case let .function(function, membership):
Expand Down
Loading