test: handle paykit ui switch#163
Merged
Merged
Conversation
Collaborator
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit cb9378c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low-risk test-only changes that mainly adjust E2E setup/navigation; primary risk is increased flakiness if the Paykit toggle/toasts or dev-settings UI changes.
Overview
Ensures Paykit-related E2E coverage runs with the Paykit UI feature enabled by adding a
test/helpers/paykit.tshelper that navigates to Dev Settings, scrolls to/togglesPaykitUiToggle, handles the optional enable confirmation dialog, and waits for newPaykitUiEnabledToast/PaykitUiDisabledToast.Updates navigation helpers with
openDevSettings()and modifiespaykit.e2e.tsandpubky-profile.e2e.tsto callenablePaykitUi()duringbeforeEach(and after reinstall mid-test), making tests resilient to the UI being off by default.Reviewed by Cursor Bugbot for commit cb9378c. Bugbot is set up for automated code reviews on this repo. Configure here.