feat: PgBouncer migration tooling — config parser, converter + proxysql-cli, and PgBouncer-compatible SHOW commands - #5566
feat: PgBouncer migration tooling — config parser, converter + proxysql-cli, and PgBouncer-compatible SHOW commands#5566renecannao wants to merge 12 commits into
Quality Gate passed
Annotations
Check failure on line 5570 in lib/Admin_Handler.cpp
sonarqubecloud / SonarCloud Code Analysis
C-style cast removing const qualification from the type of a pointer may lead to undefined behavior.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcahrCl9tnd_kUVmq&open=AaBCcahrCl9tnd_kUVmq&pullRequest=5566
Check failure on line 76 in lib/pgbouncer_compat/PgBouncer_HBAParser.cpp
sonarqubecloud / SonarCloud Code Analysis
Call a function from <locale> instead of a function from <ctype.h>.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcaj5Cl9tnd_kUVm8&open=AaBCcaj5Cl9tnd_kUVm8&pullRequest=5566
Check failure on line 14 in test/tap/tests/unit/pgbouncer_converter_unit-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Replace this function-like macro with a C++ function or another construct.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcaWvCl9tnd_kUVmM&open=AaBCcaWvCl9tnd_kUVmM&pullRequest=5566
Check failure on line 60 in lib/pgbouncer_compat/PgBouncer_HBAParser.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcaj5Cl9tnd_kUVm6&open=AaBCcaj5Cl9tnd_kUVm6&pullRequest=5566
Check failure on line 35 in lib/pgbouncer_compat/ProxySQL_CLI.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 27 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcakACl9tnd_kUVm9&open=AaBCcakACl9tnd_kUVm9&pullRequest=5566
Check failure on line 114 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 44 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcakLCl9tnd_kUVnA&open=AaBCcakLCl9tnd_kUVnA&pullRequest=5566
Check failure on line 274 in lib/pgbouncer_compat/PgBouncer_ConfigConverter.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture "result" in a non-transient lambda.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcajyCl9tnd_kUVm1&open=AaBCcajyCl9tnd_kUVm1&pullRequest=5566
Check failure on line 5632 in lib/Admin_Handler.cpp
sonarqubecloud / SonarCloud Code Analysis
C-style cast removing const qualification from the type of a pointer may lead to undefined behavior.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcahrCl9tnd_kUVmu&open=AaBCcahrCl9tnd_kUVmu&pullRequest=5566
Check failure on line 16 in test/tap/tests/unit/pgbouncer_config_parser_unit-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Replace this function-like macro with a C++ function or another construct.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcadACl9tnd_kUVmd&open=AaBCcadACl9tnd_kUVmd&pullRequest=5566
Check warning on line 353 in test/tap/tests/unit/pgbouncer_converter_unit-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Make sure using this hardcoded IP address is safe here.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcaWvCl9tnd_kUVmT&open=AaBCcaWvCl9tnd_kUVmT&pullRequest=5566
Check warning on line 329 in test/tap/tests/unit/pgbouncer_converter_unit-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Make sure using this hardcoded IP address is safe here.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcaWvCl9tnd_kUVmS&open=AaBCcaWvCl9tnd_kUVmS&pullRequest=5566
Check failure on line 152 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcakLCl9tnd_kUVnB&open=AaBCcakLCl9tnd_kUVnB&pullRequest=5566
Check failure on line 18 in lib/pgbouncer_compat/PgBouncer_ShowCommands.cpp
sonarqubecloud / SonarCloud Code Analysis
Call a function from <locale> instead of a function from <ctype.h>.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcajoCl9tnd_kUVmw&open=AaBCcajoCl9tnd_kUVmw&pullRequest=5566
Check failure on line 419 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 37 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcakLCl9tnd_kUVnI&open=AaBCcakLCl9tnd_kUVnI&pullRequest=5566
Check failure on line 304 in lib/pgbouncer_compat/PgBouncer_ConfigConverter.cpp
sonarqubecloud / SonarCloud Code Analysis
Call a function from <locale> instead of a function from <ctype.h>.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcajyCl9tnd_kUVm3&open=AaBCcajyCl9tnd_kUVm3&pullRequest=5566
Check failure on line 44 in lib/pgbouncer_compat/PgBouncer_HBAParser.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 27 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcaj5Cl9tnd_kUVm5&open=AaBCcaj5Cl9tnd_kUVm5&pullRequest=5566
Check failure on line 67 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp
sonarqubecloud / SonarCloud Code Analysis
Call a function from <locale> instead of a function from <ctype.h>.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcakLCl9tnd_kUVm_&open=AaBCcakLCl9tnd_kUVm_&pullRequest=5566
Check warning on line 5604 in lib/Admin_Handler.cpp
sonarqubecloud / SonarCloud Code Analysis
Make sure use of "strlen" is safe here.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcahrCl9tnd_kUVms&open=AaBCcahrCl9tnd_kUVms&pullRequest=5566
Check failure on line 43 in test/tap/tests/pgsql-pgbouncer_compat-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Use "std::size" to get the size of this array.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcadRCl9tnd_kUVmi&open=AaBCcadRCl9tnd_kUVmi&pullRequest=5566
Check failure on line 5617 in lib/Admin_Handler.cpp
sonarqubecloud / SonarCloud Code Analysis
C-style cast removing const qualification from the type of a pointer may lead to undefined behavior.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcahrCl9tnd_kUVmt&open=AaBCcahrCl9tnd_kUVmt&pullRequest=5566
Check failure on line 5531 in lib/Admin_Handler.cpp
sonarqubecloud / SonarCloud Code Analysis
C-style cast removing const qualification from the type of a pointer may lead to undefined behavior.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcahrCl9tnd_kUVmp&open=AaBCcahrCl9tnd_kUVmp&pullRequest=5566
Check failure on line 282 in lib/pgbouncer_compat/PgBouncer_ConfigConverter.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture "result" in a non-transient lambda.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcajyCl9tnd_kUVm2&open=AaBCcajyCl9tnd_kUVm2&pullRequest=5566
Check failure on line 5523 in lib/Admin_Handler.cpp
sonarqubecloud / SonarCloud Code Analysis
C-style cast removing const qualification from the type of a pointer may lead to undefined behavior.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcahrCl9tnd_kUVmo&open=AaBCcahrCl9tnd_kUVmo&pullRequest=5566
Check failure on line 533 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 75 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcakLCl9tnd_kUVnJ&open=AaBCcakLCl9tnd_kUVnJ&pullRequest=5566
Check failure on line 174 in lib/pgbouncer_compat/PgBouncer_ConfigParser.cpp
sonarqubecloud / SonarCloud Code Analysis
Call a function from <locale> instead of a function from <ctype.h>.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBCcakLCl9tnd_kUVnG&open=AaBCcakLCl9tnd_kUVnG&pullRequest=5566