Skip to content

test(pg-compat): SP-1..SP-3 combined — PG protocol coverage, polyglot foundation, driver matrix (supersedes #5894, #5903, #5910) - #6020

Merged
renecannao merged 66 commits into
v3.0from
test/pgsql-compat-sp1-sp3-combined
Aug 10, 2026
Merged

test(pg-compat): SP-1..SP-3 combined — PG protocol coverage, polyglot foundation, driver matrix (supersedes #5894, #5903, #5910)#6020
renecannao merged 66 commits into
v3.0from
test/pgsql-compat-sp1-sp3-combined

fix: address CodeRabbit, gitar-bot and codex review findings

afac510
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 10, 2026 in 1m 17s

Quality Gate passed

Issues
42 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 61 in test/tap/tests/pgsql-datatype_matrix-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using this hardcoded IP address is safe here. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPS_UUduJcvPJEwa0&open=AZ_qPS_UUduJcvPJEwa0&pullRequest=6020

Check warning on line 296 in test/pg-compat/drivers/prisma/behaviors.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTEuUduJcvPJEwbU&open=AZ_qPTEuUduJcvPJEwbU&pullRequest=6020

Check failure on line 491 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwbI&open=AZ_qPTDtUduJcvPJEwbI&pullRequest=6020

Check failure on line 466 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwbA&open=AZ_qPTDtUduJcvPJEwbA&pullRequest=6020

Check warning on line 161 in test/pg-compat/drivers/prisma/behaviors.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTEtUduJcvPJEwbS&open=AZ_qPTEtUduJcvPJEwbS&pullRequest=6020

Check failure on line 481 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwbE&open=AZ_qPTDtUduJcvPJEwbE&pullRequest=6020

Check failure on line 479 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwa7&open=AZ_qPTDtUduJcvPJEwa7&pullRequest=6020

Check warning on line 70 in test/pg-compat/Dockerfile

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Sort these package names alphanumerically. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTFJUduJcvPJEwbm&open=AZ_qPTFJUduJcvPJEwbm&pullRequest=6020

Check failure on line 339 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwa3&open=AZ_qPTDtUduJcvPJEwa3&pullRequest=6020

Check failure on line 36 in test/pg-compat/run-pg-compat.bash

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTFBUduJcvPJEwba&open=AZ_qPTFBUduJcvPJEwba&pullRequest=6020

Check warning on line 110 in test/pg-compat/Dockerfile

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this RUN instruction with the consecutive ones. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qXa5oQFUv8-OU7Ivu&open=AZ_qXa5oQFUv8-OU7Ivu&pullRequest=6020

Check failure on line 471 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwbC&open=AZ_qPTDtUduJcvPJEwbC&pullRequest=6020

Check warning on line 115 in test/tap/tests/pgsql-server_side_cursors-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "todo" comment. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTEJUduJcvPJEwbN&open=AZ_qPTEJUduJcvPJEwbN&pullRequest=6020

Check failure on line 501 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwbK&open=AZ_qPTDtUduJcvPJEwbK&pullRequest=6020

Check warning on line 116 in test/tap/tests/pgsql-server_side_cursors-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "todo" comment. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTEJUduJcvPJEwbO&open=AZ_qPTEJUduJcvPJEwbO&pullRequest=6020

Check warning on line 189 in test/pg-compat/drivers/node/behaviors.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`new Error()` is too unspecific for a type check. Use `new TypeError()` instead. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTE4UduJcvPJEwbX&open=AZ_qPTE4UduJcvPJEwbX&pullRequest=6020

Check failure on line 473 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwbD&open=AZ_qPTDtUduJcvPJEwbD&pullRequest=6020

Check failure on line 495 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwbG&open=AZ_qPTDtUduJcvPJEwbG&pullRequest=6020

Check warning on line 20 in test/pg-compat/Dockerfile

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this invocation of "curl" with the ADD instruction. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qXa5oQFUv8-OU7Ivv&open=AZ_qXa5oQFUv8-OU7Ivv&pullRequest=6020

Check warning on line 39 in test/pg-compat/drivers/node/behaviors.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseInt` over `parseInt`. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTE4UduJcvPJEwbW&open=AZ_qPTE4UduJcvPJEwbW&pullRequest=6020

Check failure on line 495 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwbH&open=AZ_qPTDtUduJcvPJEwbH&pullRequest=6020

Check warning on line 283 in test/pg-compat/drivers/node/behaviors.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTE4UduJcvPJEwbZ&open=AZ_qPTE4UduJcvPJEwbZ&pullRequest=6020

Check warning on line 284 in test/pg-compat/drivers/prisma/behaviors.mjs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'Object.hasOwn()' instead of 'Object.prototype.hasOwnProperty.call()'. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTEuUduJcvPJEwbT&open=AZ_qPTEuUduJcvPJEwbT&pullRequest=6020

Check warning on line 110 in test/pg-compat/Dockerfile

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is too long. Split it into multiple lines using backslash continuations. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTFJUduJcvPJEwbp&open=AZ_qPTFJUduJcvPJEwbp&pullRequest=6020

Check warning on line 483 in test/tap/tests/pg_lite_client.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure use of "strlen" is safe here. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ_qPTDtUduJcvPJEwbF&open=AZ_qPTDtUduJcvPJEwbF&pullRequest=6020
View more details on SonarQubeCloud