Skip to content

fix(build): make tap unit_tests wait for the tap library directory (intermittent 'libcurl.so: file too short') #6024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renecannao merged 1 commit into from
Aug 10, 2026
Merged

fix(build): make tap unit_tests wait for the tap library directory (intermittent 'libcurl.so: file too short') #6024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion test/tap/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,24 @@ tests_with_deps: tap test_deps
cd tests_with_deps && CC=${CC} CXX=${CXX} ${MAKE} $(MAKECMDGOALS)


# `tap test_deps` is NOT optional here, even though nothing under tests/unit is
# built by those targets. The unit tests link -lcurl with -L$(TAP_LDIR), i.e.
# test/tap/tap, and the `tap` recipe populates that directory by copying the
# vendored library into it:
#
# libcurl$(SHLIB_EXT): $(DEPS_PATH)/curl/curl/lib/.libs/libcurl$(SHLIB_EXT)
# cp -a $(DEPS_PATH)/curl/curl/lib/.libs/libcurl$(SHLIB_EXT)* .
#
# Without this prerequisite `unit_tests` runs CONCURRENTLY with `tap` under the
# `all`/`debug` targets above, so a unit test's linker can open libcurl.so while
# that cp is still writing it and fail with `file too short`. Intermittent by
# nature -- it needs the copy and a link to overlap -- and it presents as a
# corrupt library rather than a build-order problem, which makes it easy to
# misread as a real toolchain or dependency failure. Every sibling target here
# (tests, tests_no_infra, tests_with_deps) already declares these prerequisites;
# unit_tests was the only one that did not.
.PHONY: unit_tests
unit_tests:
unit_tests: tap test_deps
cd tests/unit && CC=${CC} CXX=${CXX} ${MAKE} $(MAKECMDGOALS)


Expand Down
Loading