fix(ci): hand off GenAI plugin to AI shards

.github/scripts/tests/test-genai-plugin-handoff.py

@@ -0,0 +1,99 @@
+#!/usr/bin/env python3
+from pathlib import Path
+import subprocess
+import tempfile
+
+import yaml
+
+
+ROOT = Path(__file__).resolve().parents[3]
+
+
+def workflow_steps(path: str, job: str) -> list[dict]:
+    with (ROOT / path).open(encoding="utf-8") as stream:
+        workflow = yaml.safe_load(stream)
+    return workflow["jobs"][job]["steps"]
+
+
+def named_step(steps: list[dict], name: str) -> dict:
+    for step in steps:
+        if step.get("name") == name:
+            return step
+    raise AssertionError(f"workflow step not found: {name}")
+
+
+def run_script(step: dict, cwd: Path) -> subprocess.CompletedProcess[str]:
+    return subprocess.run(
+        ["bash", "-c", "set -euo pipefail\n" + step["run"]],
+        cwd=cwd,
+        text=True,
+        capture_output=True,
+        check=False,
+    )
+
+
+build_steps = workflow_steps(".github/workflows/ci-builds.yml", "builds")
+ai_steps = workflow_steps(".github/workflows/ci-ai-gcov.yml", "tests")
+stage = named_step(build_steps, "Stage GenAI plugin in test handoff")
+restore = named_step(ai_steps, "Restore GenAI plugin from build handoff")
+verify = named_step(ai_steps, "Verify binary and GenAI plugin")
+
+assert "inputs.trusted" in stage["if"]
+assert "contains(matrix.type,'-genai')" in stage["if"]
+
+names = [step.get("name") for step in ai_steps]
+assert names.index("Download build handoff") < names.index(restore["name"])
+assert names.index(restore["name"]) < names.index(verify["name"])
+assert names.index(verify["name"]) < names.index("Start infrastructure")
+
+with tempfile.TemporaryDirectory() as directory:
+    cwd = Path(directory)
+    repo = cwd / "proxysql"
+    source = repo / "plugins/genai/ProxySQL_GenAI_Plugin.so"
+    source.parent.mkdir(parents=True)
+    source.write_bytes(b"genai-plugin")
+
+    result = run_script(stage, cwd)
+    assert result.returncode == 0, result.stdout + result.stderr
+    staged = repo / "test/tap/tap/_runtime_libs/ProxySQL_GenAI_Plugin.so"
+    assert staged.read_bytes() == b"genai-plugin"
+
+    source.unlink()
+    staged.unlink()
+    result = run_script(stage, cwd)
+    assert result.returncode != 0
+    assert "ProxySQL_GenAI_Plugin.so" in result.stdout + result.stderr
+
+with tempfile.TemporaryDirectory() as directory:
+    cwd = Path(directory)
+    repo = cwd / "proxysql"
+    staged = repo / "test/tap/tap/_runtime_libs/ProxySQL_GenAI_Plugin.so"
+    staged.parent.mkdir(parents=True)
+    staged.write_bytes(b"genai-plugin")
+
+    result = run_script(restore, cwd)
+    assert result.returncode == 0, result.stdout + result.stderr
+    restored = repo / "plugins/genai/ProxySQL_GenAI_Plugin.so"
+    assert restored.read_bytes() == b"genai-plugin"
+
+    staged.unlink()
+    restored.unlink()
+    result = run_script(restore, cwd)
+    assert result.returncode != 0
+    assert "ProxySQL_GenAI_Plugin.so" in result.stdout + result.stderr
+
+    binary = repo / "src/proxysql"
+    binary.parent.mkdir(parents=True)
+    binary.write_bytes(b"#!/bin/sh\nexit 0\n")
+    binary.chmod(0o755)
+    restored.parent.mkdir(parents=True, exist_ok=True)
+    restored.write_bytes(b"genai-plugin")
+    result = run_script(verify, cwd)
+    assert result.returncode == 0, result.stdout + result.stderr
+
+    restored.unlink()
+    result = run_script(verify, cwd)
+    assert result.returncode != 0
+    assert "ProxySQL_GenAI_Plugin.so" in result.stdout + result.stderr
+
+print("GenAI plugin handoff contract passed")

.github/workflows/ci-ai-gcov.yml

@@ -118,10 +118,28 @@ jobs:
         done
         rm -f ../cache_*.tar.zst ../handoff-*.zip
 
-    - name: Verify binary
+    - name: Restore GenAI plugin from build handoff
+      run: |
+        set -euo pipefail
+        cd proxysql/
+        plugin_src="test/tap/tap/_runtime_libs/ProxySQL_GenAI_Plugin.so"
+        plugin_dest="plugins/genai/ProxySQL_GenAI_Plugin.so"
+        if [ ! -s "${plugin_src}" ]; then
+          echo "ERROR: required GenAI plugin missing from build handoff: ${plugin_src}" >&2
+          exit 1
+        fi
+        mkdir -p "$(dirname "${plugin_dest}")"
+        cp "${plugin_src}" "${plugin_dest}"
+        test -s "${plugin_dest}"
+
+    - name: Verify binary and GenAI plugin
       run: |
         chmod +x proxysql/src/proxysql
         file proxysql/src/proxysql
+        test -s proxysql/plugins/genai/ProxySQL_GenAI_Plugin.so || {
+          echo "ERROR: ProxySQL_GenAI_Plugin.so was not restored" >&2
+          exit 1
+        }
 
     - name: Log in to GHCR and pull CI base image
       env:

.github/workflows/ci-builds.yml

@@ -564,6 +564,22 @@ jobs:
           grep 'exited with code 0' ${LOG} || exit 1
         done
 
+    - name: Stage GenAI plugin in test handoff
+      if: ${{ inputs.trusted && success() && steps.cache-check.outputs.cache-hit != 'true' && contains(matrix.type,'-genai') }}
+      run: |
+        set -euo pipefail
+        cd proxysql/
+        plugin_src="plugins/genai/ProxySQL_GenAI_Plugin.so"
+        plugin_dest="test/tap/tap/_runtime_libs/ProxySQL_GenAI_Plugin.so"
+        if [ ! -s "${plugin_src}" ]; then
+          echo "ERROR: required GenAI plugin missing after build: ${plugin_src}" >&2
+          exit 1
+        fi
+        mkdir -p "$(dirname "${plugin_dest}")"
+        cp -L "${plugin_src}" "${plugin_dest}"
+        test -s "${plugin_dest}"
+        ls -la "$(dirname "${plugin_dest}")"
+
     - name: Pack bin cache with zstd-15
       id: cache-pack-bin
       if: ${{ inputs.trusted && success() && steps.cache-check.outputs.cache-hit != 'true' }}