Feature/review pgsql native backend protocol - #6112
Quality Gate failed
Failed conditions
See analysis details on SonarQube Cloud
Annotations
Check failure on line 2372 in lib/PgSQL_Connection.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 61 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAWAgh6SFm3-MqvYldp&open=AaAWAgh6SFm3-MqvYldp&pullRequest=6112
Check failure on line 1979 in lib/PgSQL_Connection.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAWAgh6SFm3-MqvYldn&open=AaAWAgh6SFm3-MqvYldn&pullRequest=6112
Check failure on line 335 in test/tap/tests/pgsql-native_ssl_pool_reuse-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture "seen", "srvPresent" in a non-transient lambda.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAWAgEnSFm3-MqvYldJ&open=AaAWAgEnSFm3-MqvYldJ&pullRequest=6112
Check failure on line 234 in test/tap/tests/pgsql-native_ssl_pool_reuse-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture "admin" in a non-transient lambda.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAWAgEnSFm3-MqvYldA&open=AaAWAgEnSFm3-MqvYldA&pullRequest=6112
Check failure on line 599 in test/tap/tests/pgsql_mock_backend.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaA4AdU24eJz4KEIj4En&open=AaA4AdU24eJz4KEIj4En&pullRequest=6112
Check failure on line 459 in test/tap/tests/pgsql-native_auth_matrix-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture "admin" in a non-transient lambda.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBrBHSME8II2voIZfFV&open=AaBrBHSME8II2voIZfFV&pullRequest=6112
Check failure on line 309 in test/tap/tests/pgsql-native_concurrency-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture "saved_maxconn", "admin", "saved_native" in a non-transient lambda.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaB6glwAj0u9k_5nQERP&open=AaB6glwAj0u9k_5nQERP&pullRequest=6112
Check failure on line 385 in test/tap/tests/pgsql-native_auth_matrix-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 150 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBrBHSME8II2voIZfFS&open=AaBrBHSME8II2voIZfFS&pullRequest=6112
Check failure on line 103 in lib/PgSQL_Backend_Auth.cpp
sonarqubecloud / SonarCloud Code Analysis
Make sure this weak hash algorithm is not used in a sensitive context here.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBrBHajE8II2voIZfFa&open=AaBrBHajE8II2voIZfFa&pullRequest=6112
Check warning on line 119 in lib/PgSQL_Backend_Auth.cpp
sonarqubecloud / SonarCloud Code Analysis
Make sure use of "strlen" is safe here.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBrBHajE8II2voIZfFd&open=AaBrBHajE8II2voIZfFd&pullRequest=6112
Check warning on line 719 in test/tap/tests/unit/pgsql_backend_auth-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Make sure use of "strlen" is safe here.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBrBG9LE8II2voIZfFJ&open=AaBrBG9LE8II2voIZfFJ&pullRequest=6112
Check failure on line 176 in test/tap/tests/unit/pgsql_conn_liveness_unit-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Rewrite the code so that you no longer need this "delete".
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaB6glUaj0u9k_5nQERK&open=AaB6glUaj0u9k_5nQERK&pullRequest=6112
Check failure on line 262 in test/tap/tests/pgsql-native_ssl_pool_reuse-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture "admin" in a non-transient lambda.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAWAgEnSFm3-MqvYldD&open=AaAWAgEnSFm3-MqvYldD&pullRequest=6112
Check failure on line 532 in test/tap/tests/pgsql-native_auth_matrix-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture "admin" in a non-transient lambda.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBrBHSME8II2voIZfFX&open=AaBrBHSME8II2voIZfFX&pullRequest=6112
Check failure on line 1627 in lib/PgSQL_Connection.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 44 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAWAgh6SFm3-MqvYldh&open=AaAWAgh6SFm3-MqvYldh&pullRequest=6112
Check failure on line 381 in test/tap/tests/pgsql-native_ssl_pool_reuse-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture "probeSsl" in a non-transient lambda.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAWAgEnSFm3-MqvYldK&open=AaAWAgEnSFm3-MqvYldK&pullRequest=6112
Check failure on line 76 in test/tap/tests/unit/pgsql_conn_liveness_unit-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Rewrite the code so that you no longer need this "delete".
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaB6glUaj0u9k_5nQERC&open=AaB6glUaj0u9k_5nQERC&pullRequest=6112
Check failure on line 297 in test/tap/tests/pgsql-native_pool_reset-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 37 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaCLR9jRG_dh45HuXExU&open=AaCLR9jRG_dh45HuXExU&pullRequest=6112
Check warning on line 748 in test/tap/tests/unit/pgsql_backend_auth-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Make sure use of "strlen" is safe here.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBrBG9LE8II2voIZfFL&open=AaBrBG9LE8II2voIZfFL&pullRequest=6112
Check failure on line 719 in test/tap/tests/pgsql-native_ssl_pool_reuse-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAWAgEnSFm3-MqvYlc-&open=AaAWAgEnSFm3-MqvYlc-&pullRequest=6112
Check failure on line 2582 in lib/PgSQL_Connection.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if|for|do|while|switch statements.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBrBHfkE8II2voIZfFe&open=AaBrBHfkE8II2voIZfFe&pullRequest=6112
Check failure on line 492 in test/tap/tests/pgsql-native_ssl_pool_reuse-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly capture "poolCountHG" in a non-transient lambda.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAWAgEnSFm3-MqvYldO&open=AaAWAgEnSFm3-MqvYldO&pullRequest=6112
Check failure on line 2233 in lib/PgSQL_Connection.cpp
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 72 to the 25 allowed.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaAWAgh6SFm3-MqvYldo&open=AaAWAgh6SFm3-MqvYldo&pullRequest=6112
Check warning on line 20 in test/tap/tests/unit/pgsql_backend_auth-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Make sure use of "strlen" is safe here.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBrBG9LE8II2voIZfFD&open=AaBrBG9LE8II2voIZfFD&pullRequest=6112
Check warning on line 803 in test/tap/tests/unit/pgsql_backend_auth-t.cpp
sonarqubecloud / SonarCloud Code Analysis
Make sure use of "strlen" is safe here.
See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AaBrBG9LE8II2voIZfFP&open=AaBrBG9LE8II2voIZfFP&pullRequest=6112