Repository navigation
ci(release): declare registry.npmjs.org for the release-gate planner's npm:effect import - #28
Merged
Merged
Conversation
…s npm:effect import The Release gate failed on main at 27107a0 (run 37581046981, job "plan · mutation shards"). Its first step runs scripts/stryker-plan-gate.ts in the sandbox with jsr.io as the only declared host. The planner imports npm:effect through scripts/deno.json, so Deno's fetch of registry.npmjs.org/effect was refused, the step exited 1 and every mutation shard was skipped. Both planner steps, "Discover mutation projects" and "Gate the plan", now declare jsr.io and registry.npmjs.org, the same pair gate:tasks declares. The gate step happened to reuse the Deno cache the discover step left in the project's .cache, but its own imports resolve the same npm package, so it declares the host too. Nothing else is widened. sandbox-proofs/release-gate-planner.test.ts runs in test:sandbox, which check:ci and the CI test leg run. It reads every sandbox step in release-gate.yml's plan job that runs scripts/stryker-plan-gate.ts and takes each step's hosts and command from the workflow, not from a copy. It then runs each command through sandbox --allow-host on those hosts, against a fixture workspace and plan, with the step's Deno cache cleared first. Both steps must exit 0, discover must list the fixture's mutating package, and the gate must emit has-shards=true. As a sabotage proof, with main's release-gate.yml the test fails on "Discover mutation projects" with the same "egress to registry.npmjs.org:443 refused" lines as the CI log. With registry.npmjs.org dropped from the gate step only, it fails on "Gate the plan" with "Failed caching npm package 'effect@4.0.1'" CONST-W3: release-gate.yml is an evaluator surface (AGENTS.md Boundaries, CONST-E9), and the test is a new check. Both are added on the explicit ruling of their owner (Kiro), not on the maker's own judgment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red Release gate on main at
27107a0(#13's squash).Root cause
Run 37581046981, job "plan · mutation shards" (112660538757). The first planner step, "Discover mutation projects", runs
scripts/stryker-plan-gate.tsin the sandbox withjsr.ioas its only declared host. The planner importsnpm:effect(throughscripts/deno.json), so Deno's fetch ofregistry.npmjs.org/effectwas refused:The step exited 1, so
has-shardswas never published and every mutation shard was skipped. Main has no mutation result.Change
.github/workflows/release-gate.yml: both Deno planner steps ("Discover mutation projects" and "Gate the plan") now declarejsr.ioandregistry.npmjs.org, the same pairgate:tasksdeclares. This is consumption only, allowed by the no-npm scope ruling..cache. Its own imports resolve the same npm package, so it declares the host as well.stryker planstep already had both hosts; the shard step is unchanged.sandbox-proofs/release-gate-planner.test.tsruns intest:sandbox, whichcheck:ciand the CI test leg run. No new job.release-gate.ymland takes, from the workflow itself rather than a copy, eachplan-job sandbox step that runsscripts/stryker-plan-gate.ts: itshostsandcommand.sandbox --allow-host …on exactly those hosts. The fixture is a workspace with one mutating package and a one-shard plan, and each step's Deno cache is cleared first.packages/core, and the gate must emithas-shards=true.Sabotage (local, throwaway copy)
release-gate.ymljsr.ioonly)"Discover mutation projects" exited 1, with the sameegress to registry.npmjs.org:443 refusedlines as the CI logregistry.npmjs.orgdropped from "Gate the plan" only"Gate the plan" exited 1,Failed caching npm package 'effect@4.0.1'Verified locally on
d880005pnpm bootstrap0 ·pnpm format:check0 ·pnpm gate:tasks9/9 ·pnpm gate:dist2/2 ·pnpm test:sandbox4 passed (13 steps), including the new test · commitlint 0. No stryker ran locally.The Release gate dispatched on this branch is the proof that the planner succeeds and the shards run real mutants. Its run id and per-shard mutant counts are posted below.
CONST-W3:
release-gate.ymlis an evaluator surface (AGENTS.md Boundaries, CONST-E9), and the test is a new check. Both are added on the explicit ruling of their owner (Kiro).