Skip to content

ci(release): adopt pnpm-release-management #11's caller contract - #32

Closed
systemfsoftware-maker wants to merge 2 commits into
mainfrom
xs/release-prm11
Closed

systemfsoftware-maker wants to merge 2 commits into
mainfrom
xs/release-prm11

Conversation

@systemfsoftware-maker

@systemfsoftware-maker systemfsoftware-maker commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Draft: do not merge. The intent check passes at this pin, but the release-PR path cannot keep the packages on their alpha line. #32 merges once a pnpm-release-management revision fixes the three gaps below; then the flake input is bumped and the probe re-run.

Gaps at pnpm-release-management aa712d95

release.jsonc now uses versioning: { strategy: "changesets" }, because the schema at this pin offers only surfaces (one version) and changesets. nix develop -c sandbox -- changeset-management check origin/main exits 0 and names all six publishable packages. version-management bump, probed on a throwaway detached copy of this branch:

  1. Pre mode is ignored. packages/changesets-adapter/src/ChangesetsPortLive.ts:98 calls assembleReleasePlan(changesets, packages, config, undefined). The preState is hard-coded undefined, .changeset/pre.json is never read, and no config key exists. The debut minor intents give:

    Package Now After bump
    @systemfsoftware/xstate 6.0.0-alpha.64 6.0.0
    @systemfsoftware/xstate-effect 0.1.0-alpha.7 0.1.0
    @systemfsoftware/xstate-react 7.0.0-alpha.4 7.0.0
    @systemfsoftware/xstate-store 5.0.0-alpha.5 5.0.0
    @systemfsoftware/xstate-store-react 2.1.0-alpha.3 2.1.0
    @systemfsoftware/xstate-test 2.0.0-alpha.1 2.0.0
  2. Root version required under changesets. packages/version-engine/src/bump.ts:49 reads the root manifest version regardless of strategy (apps/version-management/src/boundary.ts:36, ROOT_TARGET = package.json). The README documents versioning.manifest as surfaces-only. This workspace's private root has no version, so bump fails with VersionIntentMalformed: path=package.json.

  3. changelogDir is not created, and bump is not atomic. With a root version added in the probe copy, bump fails with ChangelogUnwritable: .changeset/changelogs/@systemfsoftware!xstate@6.0.0.md (NotFound), after it has already rewritten the six package.json versions.

No root version and no hand-made changelog directory are added here; those would be workarounds for the gaps above.

main's Release run has been red since #14. The reusable release.yml at the old pin ran a bare pnpm install --frozen-lockfile, which cannot read this repo's file:.sfs-deps tarballs (ERR_PNPM_TARBALL_READ_LOCAL_TARBALL). pnpm-release-management #11 (aa712d95) builds the caller's .#workspace-tarballs and runs its apps from the caller's dev shell. This PR adopts that caller contract.

Changes

  • release.yml: drops tools-ref, passes ci-workflow: ci.yml and runs-on: '"ubuntu-latest"' (hosted; the repo is public), and grants actions: write in addition to contents and pull-requests write.
  • ci.yml: accepts workflow_dispatch, so release.yml can dispatch CI on the release branch.
  • flake.nix:
    • Pins pnpm-release-management at aa712d95.
    • The dev shell takes that input's release-tools (changeset-management, version-management, github-release-management), and the separate release-tools pin is removed.
    • workspace-tarballs keeps its single mkPnpmWorkspacePackages definition; that library is byte-identical between the two pins.
  • nix/patches/sandbox-linked-worktree-git.patch: rebased onto aa712d95's Linux-only sandbox.sh, because the old hunks targeted files the bump removes.
  • release.jsonc: versioning.strategy moves from the removed pnpm to changesets, the schema at aa712d95 for independently versioned packages.

Verification

Command Result
nix build --rebuild .#workspace-tarballs exit 0, "no output differs"
result/index.json @systemfsoftware/xstate, xstate-effect, xstate-react, xstate-store, xstate-store-react, xstate-test
nix develop -c sh -c 'command -v changeset-management version-management github-release-management pnpm sandbox; echo $SANDBOX_PNPM_STORE' all resolve; the store path is set
pnpm test:sandbox 5 passed, 0 failed
actionlint, pnpm format:check exit 0

prm's release-tools package installs the three apps above and no binary named release-tools, so command -v release-tools cannot succeed by construction.

nix flake check --no-build and nix flake show fail on main d8c00381 as well. That failure predates this PR: they evaluate with import-from-derivation off, and the flake reads lockfiles from derivations.

After merge

Not before the gaps above are fixed. Once a prm revision covers them, this PR bumps the flake input and re-runs the bump probe. After merge, the push Release run on main should then go green, creating six tags and six GitHub Releases with no registry publish.

CONST-W3: .github/workflows/ci.yml and release.yml are evaluator surfaces. They change on the explicit ruling of their owner (Kiro, cycle 46). ci.yml gains only a workflow_dispatch trigger; no job, step or gate changes.

main's Release run has been red since #14: the reusable release.yml at the old pin ran a bare pnpm install --frozen-lockfile, and that install cannot read this repo's file:.sfs-deps tarballs (ERR_PNPM_TARBALL_READ_LOCAL_TARBALL). pnpm-release-management #11 (aa712d95) packs the caller's .#workspace-tarballs and runs its apps from the caller's dev shell

- release.yml drops tools-ref, passes ci-workflow: ci.yml and runs-on "ubuntu-latest", and grants actions: write on top of contents and pull-requests write, as prm's README requires
- ci.yml accepts workflow_dispatch, so release.yml can dispatch CI on the release branch its token-opened PR would not trigger
- flake.nix pins pnpm-release-management at aa712d95. Its dev shell takes that input's release-tools (changeset-management, version-management, github-release-management), which replaces the separate release-tools pin. workspace-tarballs keeps its one existing mkPnpmWorkspacePackages definition, whose library is byte-identical between the two pins
- nix/patches/sandbox-linked-worktree-git.patch is rebased onto aa712d95's Linux-only sandbox.sh. The old hunks targeted files the bump removes

Verified locally: nix build --rebuild .#workspace-tarballs exits 0, and its index.json lists the six @systemfsoftware/xstate* packages. The dev shell resolves the three release apps, pnpm, sandbox and SANDBOX_PNPM_STORE. pnpm test:sandbox passes, and actionlint and format:check exit 0

CONST-W3: .github/workflows/ci.yml and release.yml are evaluator surfaces. They change on the explicit ruling of their owner (Kiro, cycle 46): ci.yml gains only a workflow_dispatch trigger and no job, step or gate changes
@systemfsoftware-maker systemfsoftware-maker changed the title xs/release prm11 ci(release): adopt pnpm-release-management #11's caller contract Oct 7, 2026
…esets strategy

pnpm-release-management aa712d95 replaces the pnpm versioning strategy with surfaces (one version owned by one manifest) and changesets (per-package versions planned by the changesets libraries). This workspace versions its six packages independently, so it takes changesets. The intent gate now parses the config: changeset-management check origin/main exits 0 and names all six publishable packages

The release-PR path is not usable at this pin. version-management bump, probed on a detached copy, fails without a root package.json version (bump.ts:49). With one added, it rewrites every package off its alpha line (6.0.0-alpha.64 to 6.0.0, among others), because ChangesetsPortLive.ts:98 passes no preState, and then fails writing into the uncreated changelogDir. #32 stays a draft until a prm revision covers those three gaps
@systemfsoftware-bot

Copy link
Copy Markdown
Contributor

Superseded by #95, which moved release.yml to the shared release workflow with the changesets strategy. Gap 1 described here is still open and matters: main has no .changeset/pre.json, and release PR #111 would take every package off its alpha line (for example @systemfsoftware/xstate 6.0.0-alpha.64 to 6.0.0). #111 stays unmerged until the alpha line is decided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants