Repository navigation
ci(release): adopt pnpm-release-management #11's caller contract - #32
Closed
systemfsoftware-maker wants to merge 2 commits into
Closed
systemfsoftware-maker wants to merge 2 commits into
systemfsoftware-maker wants to merge 2 commits into
Conversation
main's Release run has been red since #14: the reusable release.yml at the old pin ran a bare pnpm install --frozen-lockfile, and that install cannot read this repo's file:.sfs-deps tarballs (ERR_PNPM_TARBALL_READ_LOCAL_TARBALL). pnpm-release-management #11 (aa712d95) packs the caller's .#workspace-tarballs and runs its apps from the caller's dev shell - release.yml drops tools-ref, passes ci-workflow: ci.yml and runs-on "ubuntu-latest", and grants actions: write on top of contents and pull-requests write, as prm's README requires - ci.yml accepts workflow_dispatch, so release.yml can dispatch CI on the release branch its token-opened PR would not trigger - flake.nix pins pnpm-release-management at aa712d95. Its dev shell takes that input's release-tools (changeset-management, version-management, github-release-management), which replaces the separate release-tools pin. workspace-tarballs keeps its one existing mkPnpmWorkspacePackages definition, whose library is byte-identical between the two pins - nix/patches/sandbox-linked-worktree-git.patch is rebased onto aa712d95's Linux-only sandbox.sh. The old hunks targeted files the bump removes Verified locally: nix build --rebuild .#workspace-tarballs exits 0, and its index.json lists the six @systemfsoftware/xstate* packages. The dev shell resolves the three release apps, pnpm, sandbox and SANDBOX_PNPM_STORE. pnpm test:sandbox passes, and actionlint and format:check exit 0 CONST-W3: .github/workflows/ci.yml and release.yml are evaluator surfaces. They change on the explicit ruling of their owner (Kiro, cycle 46): ci.yml gains only a workflow_dispatch trigger and no job, step or gate changes
…esets strategy pnpm-release-management aa712d95 replaces the pnpm versioning strategy with surfaces (one version owned by one manifest) and changesets (per-package versions planned by the changesets libraries). This workspace versions its six packages independently, so it takes changesets. The intent gate now parses the config: changeset-management check origin/main exits 0 and names all six publishable packages The release-PR path is not usable at this pin. version-management bump, probed on a detached copy, fails without a root package.json version (bump.ts:49). With one added, it rewrites every package off its alpha line (6.0.0-alpha.64 to 6.0.0, among others), because ChangesetsPortLive.ts:98 passes no preState, and then fails writing into the uncreated changelogDir. #32 stays a draft until a prm revision covers those three gaps
systemfsoftware-maker
marked this pull request as draft
October 7, 2026 17:58
This was referenced Oct 7, 2026
Contributor
|
Superseded by #95, which moved release.yml to the shared release workflow with the changesets strategy. Gap 1 described here is still open and matters: main has no .changeset/pre.json, and release PR #111 would take every package off its alpha line (for example @systemfsoftware/xstate 6.0.0-alpha.64 to 6.0.0). #111 stays unmerged until the alpha line is decided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gaps at pnpm-release-management
aa712d95release.jsoncnow usesversioning: { strategy: "changesets" }, because the schema at this pin offers onlysurfaces(one version) andchangesets.nix develop -c sandbox -- changeset-management check origin/mainexits 0 and names all six publishable packages.version-management bump, probed on a throwaway detached copy of this branch:Pre mode is ignored.
packages/changesets-adapter/src/ChangesetsPortLive.ts:98callsassembleReleasePlan(changesets, packages, config, undefined). The preState is hard-coded undefined,.changeset/pre.jsonis never read, and no config key exists. The debut minor intents give:bump@systemfsoftware/xstate@systemfsoftware/xstate-effect@systemfsoftware/xstate-react@systemfsoftware/xstate-store@systemfsoftware/xstate-store-react@systemfsoftware/xstate-testRoot version required under
changesets.packages/version-engine/src/bump.ts:49reads the root manifest version regardless of strategy (apps/version-management/src/boundary.ts:36,ROOT_TARGET = package.json). The README documentsversioning.manifestas surfaces-only. This workspace's private root has noversion, so bump fails withVersionIntentMalformed: path=package.json.changelogDiris not created, and bump is not atomic. With a root version added in the probe copy, bump fails withChangelogUnwritable: .changeset/changelogs/@systemfsoftware!xstate@6.0.0.md (NotFound), after it has already rewritten the sixpackage.jsonversions.No root
versionand no hand-made changelog directory are added here; those would be workarounds for the gaps above.main's Release run has been red since #14. The reusable
release.ymlat the old pin ran a barepnpm install --frozen-lockfile, which cannot read this repo'sfile:.sfs-depstarballs (ERR_PNPM_TARBALL_READ_LOCAL_TARBALL). pnpm-release-management #11 (aa712d95) builds the caller's.#workspace-tarballsand runs its apps from the caller's dev shell. This PR adopts that caller contract.Changes
release.yml: dropstools-ref, passesci-workflow: ci.ymlandruns-on: '"ubuntu-latest"'(hosted; the repo is public), and grantsactions: writein addition to contents and pull-requests write.ci.yml: acceptsworkflow_dispatch, sorelease.ymlcan dispatch CI on the release branch.flake.nix:pnpm-release-managementataa712d95.release-tools(changeset-management, version-management, github-release-management), and the separaterelease-toolspin is removed.workspace-tarballskeeps its singlemkPnpmWorkspacePackagesdefinition; that library is byte-identical between the two pins.nix/patches/sandbox-linked-worktree-git.patch: rebased ontoaa712d95's Linux-onlysandbox.sh, because the old hunks targeted files the bump removes.release.jsonc:versioning.strategymoves from the removedpnpmtochangesets, the schema ataa712d95for independently versioned packages.Verification
nix build --rebuild .#workspace-tarballsresult/index.json@systemfsoftware/xstate,xstate-effect,xstate-react,xstate-store,xstate-store-react,xstate-testnix develop -c sh -c 'command -v changeset-management version-management github-release-management pnpm sandbox; echo $SANDBOX_PNPM_STORE'pnpm test:sandboxactionlint,pnpm format:checkprm's
release-toolspackage installs the three apps above and no binary namedrelease-tools, socommand -v release-toolscannot succeed by construction.nix flake check --no-buildandnix flake showfail on maind8c00381as well. That failure predates this PR: they evaluate with import-from-derivation off, and the flake reads lockfiles from derivations.After merge
Not before the gaps above are fixed. Once a prm revision covers them, this PR bumps the flake input and re-runs the bump probe. After merge, the push Release run on main should then go green, creating six tags and six GitHub Releases with no registry publish.
CONST-W3:
.github/workflows/ci.ymlandrelease.ymlare evaluator surfaces. They change on the explicit ruling of their owner (Kiro, cycle 46).ci.ymlgains only aworkflow_dispatchtrigger; no job, step or gate changes.