Skip to content

Improve error message for unclosed components whose attribute value might have consumed the slash. #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianjosephwilson wants to merge 20 commits into from
+421 −36
Closed

Improve error message for unclosed components whose attribute value might have consumed the slash. #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6e295f9
Add simple copy method to allow simulating removing placeholders.
ianjosephwilson Jun 11, 2026
4077f3e
Typeguard against bogus empty starttag_text.
ianjosephwilson Jun 11, 2026
b95eaa8
Add debugging/introspection info to open tags.
ianjosephwilson Jun 11, 2026
9084150
Improve unclosed tags message for ambiguous slash case.
ianjosephwilson Jun 11, 2026
8b226fc
Fix method defn order.
ianjosephwilson Jun 12, 2026
f1b5739
Always fallback to tag str for error, fixes typecheck.
ianjosephwilson Jun 12, 2026
922c2bf
Refine error messages for other cases with trailing slash is consumed…
ianjosephwilson Jun 12, 2026
2b03b4e
Use getter directly but still guard against None.
ianjosephwilson Jun 12, 2026
a10f209
Restrict self-close suggestion to components.
ianjosephwilson Jun 12, 2026
e21b9bd
Restore component start/tag mismatch test.
ianjosephwilson Jun 15, 2026
75df60e
Add tmap and format_endtag for error reporting.
ianjosephwilson Jun 15, 2026
60095db
Be more surgical about catching nested component error.
ianjosephwilson Jun 15, 2026
323cafc
Clump parse info into class.
ianjosephwilson Jun 15, 2026
d8f98f8
Cut this out for now.
ianjosephwilson Jun 15, 2026
e3b71a7
Fold parse info tracking into source tracker.
ianjosephwilson Jun 16, 2026
4e3def3
Backport more consistent parser position and source info tracking.
ianjosephwilson Jun 24, 2026
e9a58d9
Formatting.
ianjosephwilson Jun 24, 2026
28e34e0
Actually store positions on other elements.
ianjosephwilson Jun 24, 2026
5dcc189
Test that the parser position is actually being set on the nodes.
ianjosephwilson Jun 24, 2026
0e0a842
Fold loop into test as tempfix for type issues around parser_pos.
ianjosephwilson Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading