Skip to content

Release: simplify nostr-java from 9 modules to 4, WebSocket improvements, and bug fixes#516

Merged
tcheeric merged 20 commits into
mainfrom
develop
Feb 24, 2026
Merged

Release: simplify nostr-java from 9 modules to 4, WebSocket improvements, and bug fixes#516
tcheeric merged 20 commits into
mainfrom
develop

fix: address Codex PR review comments

87ba1a0
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / Qodana Community for JVM completed Feb 24, 2026 in 0s

33 new problems found by Qodana Community for JVM

Qodana Community for JVM

33 new problems were found

Inspection name Severity Problems
Declaration has problems in Javadoc references 🔶 Warning 14
Unused import 🔶 Warning 3
Constant values 🔶 Warning 2
Lombok @Getter may be used 🔶 Warning 2
Unchecked warning 🔶 Warning 2
Default annotation parameter value 🔶 Warning 1
Deprecated API usage 🔶 Warning 1
Field can be local variable 🔶 Warning 1
Field may be 'final' 🔶 Warning 1
Manual array to collection copy 🔶 Warning 1
@NotNull/@Nullable problems 🔶 Warning 1
Suspicious variable/parameter name combination 🔶 Warning 1
Non-distinguishable logging calls ◽️ Notice 2
@NotNull/@Nullable problems ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 610 in nostr-java-client/src/main/java/nostr/client/springwebsocket/NostrRelayClient.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Condition `lastFailure == null` is always `false`

Check warning on line 597 in nostr-java-client/src/main/java/nostr/client/springwebsocket/NostrRelayClient.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Condition `attempt <= NostrRetryable.MAX_ATTEMPTS` is always `true`

Check warning on line 17 in nostr-java-client/src/main/java/nostr/client/springwebsocket/NostrRetryable.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Default annotation parameter value

Redundant default parameter value assignment

Check warning on line 16 in nostr-java-client/src/main/java/nostr/client/springwebsocket/NostrRetryable.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Deprecated API usage

'include' is deprecated

Check warning on line 72 in nostr-java-client/src/main/java/nostr/client/springwebsocket/NostrRelayClient.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field can be local variable

Field can be converted to a local variable

Check warning on line 72 in nostr-java-client/src/main/java/nostr/client/springwebsocket/NostrRelayClient.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final'

Field `maxEventsPerRequest` may be 'final'

Check warning on line 81 in nostr-java-core/src/main/java/nostr/util/exception/NostrCryptoException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Cannot resolve symbol `verify()`

Check warning on line 124 in nostr-java-core/src/main/java/nostr/crypto/bech32/Bech32Prefix.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Symbol `nostr.base.PublicKey` is inaccessible from here

Check warning on line 80 in nostr-java-core/src/main/java/nostr/util/exception/NostrCryptoException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Symbol `nostr.id.Identity` is inaccessible from here

Check warning on line 69 in nostr-java-core/src/main/java/nostr/util/exception/NostrProtocolException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Symbol `validate()` is inaccessible from here

Check warning on line 81 in nostr-java-core/src/main/java/nostr/util/exception/NostrCryptoException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Symbol `nostr.event.impl.GenericEvent` is inaccessible from here

Check warning on line 111 in nostr-java-core/src/main/java/nostr/util/exception/NostrEncodingException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Symbol `nostr.event.json.codec.BaseEventEncoder` is inaccessible from here

Check warning on line 80 in nostr-java-core/src/main/java/nostr/util/exception/NostrCryptoException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Cannot resolve symbol `sign(nostr.event.impl.GenericEvent)`

Check warning on line 125 in nostr-java-core/src/main/java/nostr/crypto/bech32/Bech32Prefix.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Cannot resolve symbol `toBech32()`

Check warning on line 115 in nostr-java-core/src/main/java/nostr/util/exception/NostrNetworkException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Symbol `nostr.client.springwebsocket.NostrRelayClient` is inaccessible from here

Check warning on line 80 in nostr-java-core/src/main/java/nostr/util/exception/NostrCryptoException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Symbol `nostr.event.impl.GenericEvent` is inaccessible from here

Check warning on line 69 in nostr-java-core/src/main/java/nostr/util/exception/NostrProtocolException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Symbol `nostr.event.impl.GenericEvent` is inaccessible from here

Check warning on line 125 in nostr-java-core/src/main/java/nostr/crypto/bech32/Bech32Prefix.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Symbol `nostr.base.PrivateKey` is inaccessible from here

Check warning on line 21 in nostr-java-event/src/main/java/nostr/event/validator/EventValidator.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Cannot resolve symbol `nostr.base.Kind`

Check warning on line 124 in nostr-java-core/src/main/java/nostr/crypto/bech32/Bech32Prefix.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Declaration has problems in Javadoc references

Cannot resolve symbol `toBech32()`

Check notice on line 522 in nostr-java-client/src/main/java/nostr/client/springwebsocket/NostrRelayClient.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Non-distinguishable logging calls

Similar log messages

Check notice on line 510 in nostr-java-client/src/main/java/nostr/client/springwebsocket/NostrRelayClient.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Non-distinguishable logging calls

Similar log messages

Check warning on line 8 in nostr-java-client/src/main/java/nostr/client/springwebsocket/RelayTimeoutException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Lombok @Getter may be used

Class 'RelayTimeoutException' may use Lombok @Getter

Check warning on line 17 in nostr-java-core/src/main/java/nostr/crypto/Point.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Lombok @Getter may be used

Class 'Point' may use Lombok @Getter

Check warning on line 34 in nostr-java-event/src/main/java/nostr/event/json/codec/GenericTagDecoder.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Manual array to collection copy

Manual array to collection copy