ci: run Windows tests against SQL Server 2025

[arthurschreiber]

Summary

• Add SQL Server 2025 to the Windows CI test matrix (now 2016, 2017, 2019, 2022, 2025).
• Update tediousjs/setup-sqlserver from @v2 to @v4 — SQL Server 2025 support was added in v3.1.0 of that action. The v3/v4 breaking changes only affect the action's own runtime (Node 24, ESM rewrite); its inputs are unchanged, so this is a drop-in upgrade.

Notes

• The Linux job already tests against SQL Server 2025 via the mcr.microsoft.com/mssql/server:2025-latest container image in test/Dockerfile, so no changes were needed there.
• The workflow passes install-updates: true, and Microsoft has not published cumulative updates for SQL Server 2025 yet — the action handles this gracefully by logging "Skipping update installation" instead of failing.

🤖 Generated with Claude Code

[claude]

Review

Small, well-scoped CI change — looks good overall.

What it does:

• Adds 2025 to the Windows test matrix (.github/workflows/nodejs.yml).
• Bumps tediousjs/setup-sqlserver from @v2 to @v4 to pick up SQL Server 2025 support (added in v3.1.0).

Verified:

• test/Dockerfile already uses mcr.microsoft.com/mssql/server:2025-latest for the Linux job, confirming the PR description's claim that Linux coverage doesn't need changes.
• The setup-sqlserver action is only referenced once in the workflow, so the version bump is self-contained — no other call sites were missed.
• mssql-version matrix values elsewhere in the workflow (job name interpolation, sqlserver-version input) are template expressions, so no other line needed updating for the new 2025 entry.

Minor notes / things worth double-checking (not blockers):

• The PR description says v3→v4 is a "drop-in upgrade" with unchanged inputs — worth a quick skim of the setup-sqlserver action's CHANGELOG/tags for v3.0.0 and v4.0.0 to confirm no input/output renames slipped in between v3.1.0 and v4, since the PR jumps two majors (v2 → v4) rather than pinning to v3.1.0 directly.
• Since install-updates: true is still passed and Microsoft hasn't published CUs for 2025 yet (per the PR description), it'd be good to confirm in the first CI run that the action truly no-ops there rather than erroring, since that's currently more of an assumption than something verified in this review.
• No test coverage concerns — this is CI infra only, and the matrix expansion is itself the "test" (first green run on 2025 validates it).

Nothing blocking; happy to see SQL Server 2025 added to Windows CI to match the existing Linux coverage.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.84%. Comparing base (650843a) to head (26cdded).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1758   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files          90       90           
  Lines        4887     4887           
  Branches      924      924           
=======================================
  Hits         3951     3951           
  Misses        640      640           
  Partials      296      296           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.